-
Notifications
You must be signed in to change notification settings - Fork 1
Implement Context Pack Conversion in textualizer #17277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 45 commits
186d7e1
97f1d4f
a567270
270defc
a959198
6a67f51
27fbb73
fc08102
48e3ecb
ef024b0
00232e5
a89b22a
ce4092e
fbbe393
a16b07c
cdb444e
63780d5
c1d1c9a
d613119
48182d5
f1cae63
ca993a5
d6459ca
e81f581
2ee2002
335abc1
20f2049
85942c0
1f30c4c
fe8b195
9ad8cfc
49d7f57
4241b6b
142e44d
e67c9b2
9723988
a1f2b4a
b87c885
77b1c2f
b332390
b4ef434
b55ef12
f570499
bb03b02
28a40c0
eaa2080
925bea1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,20 @@ | ||||||||||
| name: subsumption-bundle | ||||||||||
|
|
||||||||||
| on: | ||||||||||
| pull_request: | ||||||||||
| paths: | ||||||||||
| - "subsumption/**" | ||||||||||
| - "scripts/ci/**" | ||||||||||
| - "docs/**" | ||||||||||
| - "evidence/**" | ||||||||||
| workflow_dispatch: {} | ||||||||||
|
|
||||||||||
| jobs: | ||||||||||
| verify_subsumption_bundle: | ||||||||||
| runs-on: ubuntu-latest | ||||||||||
| steps: | ||||||||||
| - uses: actions/checkout@v4 | ||||||||||
| - uses: actions/setup-node@v4 | ||||||||||
| node-version: "20" | ||||||||||
| - name: Verify subsumption bundle | ||||||||||
| run: node scripts/ci/verify_subsumption_bundle.mjs --bundle subsumption/item-UNKNOWN | ||||||||||
|
||||||||||
| - name: Verify subsumption bundle | |
| run: node scripts/ci/verify_subsumption_bundle.mjs --bundle subsumption/item-UNKNOWN | |
| - name: Verify subsumption bundle | |
| run: node scripts/ci/verify_subsumption_bundle.mjs subsumption/item-UNKNOWN/manifest.yaml |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/subsumption-bundle.yml around lines 19 - 20, The workflow
invokes the verifier incorrectly by passing a bundle directory to the script;
update the job step that runs "node scripts/ci/verify_subsumption_bundle.mjs
--bundle subsumption/item-UNKNOWN" to supply the manifest file path expected by
the script (for example "subsumption/item-UNKNOWN/manifest.yaml") so the
existence check in verify_subsumption_bundle.mjs succeeds; keep the same
--bundle flag but point it at the manifest file (or mimic the pattern used in
the existing subsumption-bundle-verify.yml workflow).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YAML syntax error: missing
with:key.The
node-versionproperty must be nested under awith:key. The current indentation causes a YAML parsing error.🐛 Proposed fix
- uses: actions/setup-node@v4 + with: node-version: "20"📝 Committable suggestion
🧰 Tools
🪛 YAMLlint (1.38.0)
[error] 18-18: syntax error: mapping values are not allowed here
(syntax)
🤖 Prompt for AI Agents