fix: align agent data access policy checks #19507
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "version": 1, | ||
| "patterns": [ | ||
| "bypass", | ||
| "credential stuffing", | ||
| "paywall circumvention", | ||
| "scrape behind login", | ||
| "exploit" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "https://summit.example.com/schemas/agent-data-access/banned_patterns.schema.json", | ||
| "title": "Agent Data Access Banned Patterns", | ||
| "type": "object", | ||
| "additionalProperties": false, | ||
| "required": ["version", "patterns"], | ||
| "properties": { | ||
| "version": { | ||
| "type": "integer", | ||
| "minimum": 1 | ||
| }, | ||
| "patterns": { | ||
| "type": "array", | ||
| "minItems": 1, | ||
| "items": { | ||
| "type": "string", | ||
| "minLength": 1 | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| { | ||
| "version": 1, | ||
| "sources": { | ||
| "public-web": { | ||
| "id": "public-web", | ||
| "name": "Public Web Sources", | ||
| "description": "Allowlisted public sources collected without authentication.", | ||
| "classification": "PUBLIC", | ||
| "jurisdiction": ["GLOBAL"], | ||
| "lawful_basis": "public_interest", | ||
| "retention_days": 30, | ||
| "collection_methods": ["api", "secure_browser"], | ||
| "enabled": true | ||
| }, | ||
| "internal-summit-store": { | ||
| "id": "internal-summit-store", | ||
| "name": "Summit Internal Intel Store", | ||
| "description": "Summit-controlled internal intelligence datastore.", | ||
| "classification": "INTERNAL", | ||
| "jurisdiction": ["US"], | ||
| "lawful_basis": "contract", | ||
| "retention_days": 365, | ||
| "collection_methods": ["etl", "api"], | ||
| "enabled": true | ||
| }, | ||
| "restricted-provider-example": { | ||
| "id": "restricted-provider-example", | ||
| "name": "Restricted Provider Example", | ||
| "description": "Restricted provider data requiring explicit approval.", | ||
| "classification": "RESTRICTED", | ||
| "jurisdiction": ["US"], | ||
| "lawful_basis": "consent", | ||
| "retention_days": 90, | ||
| "collection_methods": ["api"], | ||
| "requires_approval": true, | ||
| "enabled": false | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| { | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "https://summit.example.com/schemas/agent-data-access/source_registry.schema.json", | ||
| "title": "Agent Data Access Source Registry", | ||
| "type": "object", | ||
| "additionalProperties": false, | ||
| "required": ["version", "sources"], | ||
| "properties": { | ||
| "version": { | ||
| "type": "integer", | ||
| "minimum": 1 | ||
| }, | ||
| "sources": { | ||
| "type": "object", | ||
| "additionalProperties": { "$ref": "#/definitions/source" } | ||
| } | ||
| }, | ||
| "definitions": { | ||
| "source": { | ||
| "type": "object", | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "id", | ||
| "name", | ||
| "description", | ||
| "classification", | ||
| "jurisdiction", | ||
| "lawful_basis", | ||
| "retention_days", | ||
| "collection_methods", | ||
| "enabled" | ||
| ], | ||
| "properties": { | ||
| "id": { "type": "string" }, | ||
| "name": { "type": "string" }, | ||
| "description": { "type": "string" }, | ||
| "classification": { | ||
| "type": "string", | ||
| "enum": ["PUBLIC", "INTERNAL", "CONFIDENTIAL", "RESTRICTED"] | ||
| }, | ||
| "jurisdiction": { | ||
| "type": "array", | ||
| "minItems": 1, | ||
| "items": { "type": "string" } | ||
| }, | ||
| "lawful_basis": { "type": "string" }, | ||
| "retention_days": { | ||
| "type": "integer", | ||
| "minimum": 1 | ||
| }, | ||
| "collection_methods": { | ||
| "type": "array", | ||
| "minItems": 1, | ||
| "items": { "type": "string" } | ||
| }, | ||
| "requires_approval": { "type": "boolean" }, | ||
| "enabled": { "type": "boolean" } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| { | ||
| "version": 1, | ||
| "tools": { | ||
| "SearchOSINT": { | ||
| "id": "SearchOSINT", | ||
| "description": "Public-only OSINT search across allowlisted sources.", | ||
| "capabilities": ["search", "osint"], | ||
| "scopes": ["public.read"], | ||
| "rateLimitPerMin": 60, | ||
| "enabled": true, | ||
| "classification": "PUBLIC" | ||
| }, | ||
| "SearchInternalIntel": { | ||
| "id": "SearchInternalIntel", | ||
| "description": "Query Summit-controlled internal intelligence stores only.", | ||
| "capabilities": ["search", "internal"], | ||
| "scopes": ["internal.read"], | ||
| "rateLimitPerMin": 30, | ||
| "enabled": true, | ||
| "classification": "INTERNAL" | ||
| }, | ||
| "FetchProviderIntel::Example": { | ||
| "id": "FetchProviderIntel::Example", | ||
| "description": "Account-backed provider API wrapper with least-privilege scopes.", | ||
| "capabilities": ["fetch", "provider"], | ||
| "scopes": ["provider.read"], | ||
| "rateLimitPerMin": 10, | ||
| "enabled": false, | ||
| "classification": "CONFIDENTIAL" | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,55 @@ | ||||||||||||||||||||||
| { | ||||||||||||||||||||||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||||||||||||||||||||||
| "$id": "https://summit.example.com/schemas/agent-data-access/tool_registry.schema.json", | ||||||||||||||||||||||
| "title": "Agent Data Access Tool Registry", | ||||||||||||||||||||||
| "type": "object", | ||||||||||||||||||||||
| "additionalProperties": false, | ||||||||||||||||||||||
| "required": ["version", "tools"], | ||||||||||||||||||||||
| "properties": { | ||||||||||||||||||||||
| "version": { | ||||||||||||||||||||||
| "type": "integer", | ||||||||||||||||||||||
| "minimum": 1 | ||||||||||||||||||||||
| }, | ||||||||||||||||||||||
| "tools": { | ||||||||||||||||||||||
| "type": "object", | ||||||||||||||||||||||
| "additionalProperties": { "$ref": "#/definitions/tool" } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| }, | ||||||||||||||||||||||
| "definitions": { | ||||||||||||||||||||||
| "tool": { | ||||||||||||||||||||||
|
Comment on lines
+15
to
+19
Contributor
There was a problem hiding this comment. The JSON schema is declared as
Suggested change
|
||||||||||||||||||||||
| "type": "object", | ||||||||||||||||||||||
| "additionalProperties": false, | ||||||||||||||||||||||
| "required": [ | ||||||||||||||||||||||
| "id", | ||||||||||||||||||||||
| "description", | ||||||||||||||||||||||
| "capabilities", | ||||||||||||||||||||||
| "scopes", | ||||||||||||||||||||||
| "rateLimitPerMin", | ||||||||||||||||||||||
| "enabled" | ||||||||||||||||||||||
| ], | ||||||||||||||||||||||
| "properties": { | ||||||||||||||||||||||
| "id": { "type": "string" }, | ||||||||||||||||||||||
| "description": { "type": "string" }, | ||||||||||||||||||||||
| "capabilities": { | ||||||||||||||||||||||
| "type": "array", | ||||||||||||||||||||||
| "minItems": 1, | ||||||||||||||||||||||
| "items": { "type": "string" } | ||||||||||||||||||||||
| }, | ||||||||||||||||||||||
| "scopes": { | ||||||||||||||||||||||
| "type": "array", | ||||||||||||||||||||||
| "minItems": 1, | ||||||||||||||||||||||
| "items": { "type": "string" } | ||||||||||||||||||||||
| }, | ||||||||||||||||||||||
| "rateLimitPerMin": { | ||||||||||||||||||||||
| "type": "integer", | ||||||||||||||||||||||
| "minimum": 1 | ||||||||||||||||||||||
| }, | ||||||||||||||||||||||
| "enabled": { "type": "boolean" }, | ||||||||||||||||||||||
| "classification": { | ||||||||||||||||||||||
| "type": "string", | ||||||||||||||||||||||
| "enum": ["PUBLIC", "INTERNAL", "CONFIDENTIAL", "RESTRICTED"] | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| { | ||
| "task_id": "AGENT_DATA_ACCESS_PR1", | ||
| "agent_id": "codex", | ||
| "prompt_ref": { | ||
| "id": "agent-data-access-policy-foundation", | ||
| "version": "v1", | ||
| "sha256": "184ac6696fe11f2eee35d0450d8dd23fb1891589f066b00eaa1da3eeb02d5126", | ||
| "path": "prompts/agent-data-access/policy-foundation@v1.md" | ||
| }, | ||
| "declared_scope": { | ||
| "paths": [ | ||
| ".github/policies/agent-data-access/", | ||
| "src/agents/policy/", | ||
| "tests/agents/policy/", | ||
| "evidence/index.json", | ||
| "evidence/EVD-OSINTLEGAL-DATAACCESS-001/", | ||
| "evidence/EVD-OSINTLEGAL-DATAACCESS-002/", | ||
| "docs/roadmap/STATUS.json", | ||
| "agents/examples/AGENT_DATA_ACCESS_PR1.json" | ||
| ], | ||
| "domains": ["governance", "policy", "evidence", "testing"] | ||
| }, | ||
| "allowed_operations": ["create", "edit"], | ||
| "verification_requirements": { | ||
| "tier": "C", | ||
| "artifacts": [ | ||
| "tests/agents/policy/policyEval.check.mjs", | ||
| "evidence/EVD-OSINTLEGAL-DATAACCESS-001", | ||
| "evidence/EVD-OSINTLEGAL-DATAACCESS-002" | ||
| ] | ||
| }, | ||
| "debt_budget": { | ||
| "permitted": 0, | ||
| "retirement_target": 0 | ||
| }, | ||
| "success_criteria": [ | ||
| "Policy registries validate against schemas, including banned patterns.", | ||
| "Deny-by-default evaluator rejects unknown tools and restricted sources without approval.", | ||
| "Evidence index updated with EVD-OSINTLEGAL-DATAACCESS-001 and EVD-OSINTLEGAL-DATAACCESS-002.", | ||
| "Roadmap status updated with PR-1 foundation entry." | ||
| ], | ||
| "stop_conditions": [ | ||
| "Schema validation fails for policy registries.", | ||
| "Evidence index update would remove existing entries.", | ||
| "Policy evaluator allows unknown tools." | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "denied_invocations": 1, | ||
| "allowed_invocations": 0 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "evidence_id": "EVD-OSINTLEGAL-DATAACCESS-001", | ||
| "summary": "Deny-by-default policy evaluator rejects unknown tool identifiers.", | ||
| "references": [ | ||
| "tests/agents/policy/policyEval.check.mjs#deny-unknown-tool" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "created_at": "2026-02-08T01:11:51Z" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "denied_invocations": 1, | ||
| "allowed_invocations": 1 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "evidence_id": "EVD-OSINTLEGAL-DATAACCESS-002", | ||
| "summary": "Restricted sources require explicit approval before access is allowed.", | ||
| "references": [ | ||
| "tests/agents/policy/policyEval.check.mjs#requires-approval-for-restricted-sources" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "created_at": "2026-02-08T01:11:51Z" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Agent Data Access Policy Foundation (PR-1) | ||
|
|
||
| ## Objective | ||
| Establish deny-by-default policy foundations for agent data access, including registries, schemas, evaluator, tests, and evidence updates. | ||
|
|
||
| ## Required Changes | ||
| - Add policy registries under `.github/policies/agent-data-access/` with JSON schemas (including banned patterns). | ||
| - Implement TypeScript policy types, loader, and evaluator under `src/agents/policy/`. | ||
| - Add unit tests covering deny-by-default and approval-required scenarios under `tests/agents/policy/`. | ||
| - Update `evidence/index.json` and add evidence artifacts for new EVD entries. | ||
| - Update `docs/roadmap/STATUS.json` with initiative status. | ||
|
|
||
| ## Constraints | ||
| - Deny-by-default for unknown tools/sources. | ||
| - Ensure banned operation patterns are enforced. | ||
| - Keep changes scoped to policy foundations (no runtime enforcement or connector behavior changes). | ||
|
|
||
| ## Verification | ||
| - Run unit tests covering policy evaluation. | ||
| - Validate policy registries against schemas. | ||
|
|
||
| ## Evidence | ||
| - Add evidence IDs `EVD-OSINTLEGAL-DATAACCESS-001` and `EVD-OSINTLEGAL-DATAACCESS-002` with report/metrics/stamp entries. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JSON schema is declared as
draft/2020-12, but it uses thedefinitionskeyword which is from older drafts. For draft 2020-12,definitionsis deprecated in favor of$defs. To align with the specified schema version, you should use$defsand update the$refaccordingly.