Skip to content

feat(leaderboard): publish result bundles #22186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BrianCLong wants to merge 3 commits into from
Closed

feat(leaderboard): publish result bundles #22186

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98fc1c4
feat(leaderboard): publish result bundles
google-labs-jules[bot] Mar 29, 2026
c0301af
fix(ci): resolve widespread CI failures
google-labs-jules[bot] Mar 29, 2026
d84d602
fix(ci): restore type definitions and fix lint rules to unblock leade…
google-labs-jules[bot] Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions evaluation/leaderboard/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
<<<<<<< HEAD
export * from './sign-result.ts';
export * from './verify-result.ts';
export * from './aggregate.ts';
export * from './leaderboard.ts';
Comment on lines 1 to 3
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It's generally recommended to omit file extensions in import and export statements in TypeScript. TypeScript's module resolver will automatically find the correct file. Including the .ts extension can cause issues with module resolution, especially when compiling to different module formats (like ESM where .js would be expected). For better portability, it's best to remove the extensions.

Suggested change
export * from './sign-result.ts';
export * from './verify-result.ts';
export * from './aggregate.ts';
export * from './leaderboard.ts';
export * from './sign-result';
export * from './aggregate';
export * from './leaderboard';

=======
export * from './sign-result';
export * from './verify-result';
export * from './aggregate';
>>>>>>> pr-21989
10 changes: 1 addition & 9 deletions evaluation/leaderboard/leaderboard.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,9 @@
<<<<<<< HEAD
import { describe, it } from 'node:test';
import assert from 'node:assert/strict';
import crypto from 'crypto';
import { createSignedResultBundle, verifyResultBundle } from './sign-result';
=======
import * as crypto from 'node:crypto';
import { signResultBundle, ResultBundlePayload } from './sign-result';
import { verifyResultBundle } from './verify-result';
>>>>>>> pr-21989
import { aggregateScores, generateLeaderboardJSON } from './aggregate';
import { buildLeaderboard } from './leaderboard';

describe('Leaderboard Utils', () => {
const { publicKey, privateKey } = crypto.generateKeyPairSync('rsa', {
Expand Down Expand Up @@ -54,7 +49,6 @@ describe('Leaderboard Utils', () => {
assert.equal(parsed.entries.length, 2);
assert.equal(parsed.entries[0].model, 'test-model-alpha');
});
<<<<<<< HEAD

it('builds leaderboard with valid signatures only', () => {
const tamperedBundle = JSON.parse(JSON.stringify(bundle1));
Expand All @@ -65,6 +59,4 @@ describe('Leaderboard Utils', () => {
assert.equal(leaderboard.entries[0].model, 'test-model-beta');
assert.equal(leaderboard.invalidBundlesCount, 1);
});
=======
>>>>>>> pr-21989
});
19 changes: 0 additions & 19 deletions evaluation/leaderboard/verify-result.ts
View file
Open in desktop

This file was deleted.

Loading