feat(skills): add Summit operational ritual skill pack#22279
Closed
BrianCLong wants to merge 1 commit intomainfrom
Closed
feat(skills): add Summit operational ritual skill pack#22279BrianCLong wants to merge 1 commit intomainfrom
BrianCLong wants to merge 1 commit intomainfrom
Conversation
BrianCLong
added
the
codex
ChatGPT Codex Connector
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the Summit Skill Pack, a collection of portable skill definitions for operating rituals such as atomic PR planning, GA readiness reviews, and trust claim auditing. The feedback focuses on improving the consistency and clarity of these skill definitions by aligning terminology between requirements and output sections, and by explicitly defining mandatory output fields and table structures to ensure deterministic agent behavior.
| 2. Demo script (setup, flow, expected outputs, failure handling) | ||
| 3. Evidence index (artifact name, source path, verification command) | ||
| 4. Validation matrix (requirement -> test -> result placeholder) | ||
| 5. Rollback and accountability window |
Contributor
There was a problem hiding this comment.
The term 'accountability window' is used here, but the corresponding output section is named ROLLBACK-AND-MONITORING (line 36). Aligning the terminology ensures the agent correctly maps this requirement to the output section.
Suggested change
| 5. Rollback and accountability window | |
| 5. Rollback and monitoring (including accountability window) |
Comment on lines
+17
to
+22
| ## Required output per claim | ||
| 1. Claim text | ||
| 2. Verdict: `SUPPORTED`, `PARTIAL`, `UNSUPPORTED`, or `CONTRADICTED` | ||
| 3. Evidence map with exact file/artifact references | ||
| 4. Confidence score (0.00-1.00) and basis | ||
| 5. Gap list and remediation actions |
Contributor
There was a problem hiding this comment.
The 'Required output per claim' list is missing the HUMAN-REVIEW-FLAGS section mentioned in the 'Output format' (line 36) and 'Rules' (line 27). Adding it here ensures the agent treats it as a mandatory part of the claim analysis.
Suggested change
| ## Required output per claim | |
| 1. Claim text | |
| 2. Verdict: `SUPPORTED`, `PARTIAL`, `UNSUPPORTED`, or `CONTRADICTED` | |
| 3. Evidence map with exact file/artifact references | |
| 4. Confidence score (0.00-1.00) and basis | |
| 5. Gap list and remediation actions | |
| ## Required output per claim | |
| 1. Claim text | |
| 2. Verdict: `SUPPORTED`, `PARTIAL`, `UNSUPPORTED`, or `CONTRADICTED` | |
| 3. Evidence map with exact file/artifact references | |
| 4. Confidence score (0.00-1.00) and basis | |
| 5. Gap list and remediation actions | |
| 6. Human review flags (for legal/compliance-sensitive language) |
| ## Output format | ||
| Return sections exactly: | ||
| - `CLAIM-INVENTORY` | ||
| - `VERDICT-TABLE` |
Contributor
There was a problem hiding this comment.
Specifying the expected columns for the VERDICT-TABLE helps the agent produce a structured and consistent summary of the audit results, including the confidence score and basis.
Suggested change
| - `VERDICT-TABLE` | |
| - `VERDICT-TABLE` (Claim, Verdict, Confidence, Basis) |
WalkthroughA Summit Skill Pack is introduced with documentation and five new skill definitions. The pack encodes repeatable operating rituals into portable skills: atomic-pr-planner, ga-gate-reviewer, pilot-proof-pack-writer, closed-pr-rehydrator, and trust-claim-auditor. Each skill includes trigger phrases, structured workflows, and explicit output contracts. Changes
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
skills/summit/README.md (1)
5-10: Consider linking each listed skill to itsSKILL.mdpath.This README is clear; adding relative links would make navigation faster for reviewers and agents.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/summit/README.md` around lines 5 - 10, Update the bullet list so each skill name is a relative markdown link to its SKILL.md (for example change `atomic-pr-planner` to `[atomic-pr-planner](atomic-pr-planner/SKILL.md)`), and do the same for `ga-gate-reviewer`, `pilot-proof-pack-writer`, `closed-pr-rehydrator`, and `trust-claim-auditor` so reviewers can click directly to each skill's documentation.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skills/summit/pilot-proof-pack-writer/SKILL.md`:
- Around line 22-36: The heading "Rollback and accountability window" is
inconsistent with the required output section name `ROLLBACK-AND-MONITORING`;
update the SKILL.md heading so it exactly matches the required section token
`ROLLBACK-AND-MONITORING` (case-sensitive) and ensure any internal references or
bullets that mention "Rollback and accountability window" use the same
`ROLLBACK-AND-MONITORING` phrasing; specifically edit the header text near the
top of SKILL.md and any occurrences in the document to use the canonical
`ROLLBACK-AND-MONITORING` token so outputs will match the expected section list.
---
Nitpick comments:
In `@skills/summit/README.md`:
- Around line 5-10: Update the bullet list so each skill name is a relative
markdown link to its SKILL.md (for example change `atomic-pr-planner` to
`[atomic-pr-planner](atomic-pr-planner/SKILL.md)`), and do the same for
`ga-gate-reviewer`, `pilot-proof-pack-writer`, `closed-pr-rehydrator`, and
`trust-claim-auditor` so reviewers can click directly to each skill's
documentation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1867ed4a-1842-4243-8357-b0d42cd5a6c3
📒 Files selected for processing (6)
skills/summit/README.mdskills/summit/atomic-pr-planner/SKILL.mdskills/summit/closed-pr-rehydrator/SKILL.mdskills/summit/ga-gate-reviewer/SKILL.mdskills/summit/pilot-proof-pack-writer/SKILL.mdskills/summit/trust-claim-auditor/SKILL.md
Comment on lines
+22
to
+36
| 5. Rollback and accountability window | ||
|
|
||
| ## Constraints | ||
| - Use deterministic headings. | ||
| - Prefer verifiable claims with explicit artifact pointers. | ||
| - If evidence is absent, mark `EVIDENCE-MISSING` and continue. | ||
| - Keep language execution-oriented, not promotional. | ||
|
|
||
| ## Output format | ||
| Return sections exactly: | ||
| - `ADR-SNAPSHOT` | ||
| - `DEMO-SCRIPT` | ||
| - `EVIDENCE-INDEX` | ||
| - `VALIDATION-MATRIX` | ||
| - `ROLLBACK-AND-MONITORING` |
There was a problem hiding this comment.
Align rollback terminology between required bundle and output section.
Line 22 says “Rollback and accountability window,” but the required section is ROLLBACK-AND-MONITORING. Use the same wording in both places to avoid ambiguous outputs.
Suggested wording alignment
-5. Rollback and accountability window
+5. Rollback and monitoring plan (including accountability window)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@skills/summit/pilot-proof-pack-writer/SKILL.md` around lines 22 - 36, The
heading "Rollback and accountability window" is inconsistent with the required
output section name `ROLLBACK-AND-MONITORING`; update the SKILL.md heading so it
exactly matches the required section token `ROLLBACK-AND-MONITORING`
(case-sensitive) and ensure any internal references or bullets that mention
"Rollback and accountability window" use the same `ROLLBACK-AND-MONITORING`
phrasing; specifically edit the header text near the top of SKILL.md and any
occurrences in the document to use the canonical `ROLLBACK-AND-MONITORING` token
so outputs will match the expected section list.
BrianCLong
added a commit
that referenced
this pull request
Mar 31, 2026
## Summary Rebuilds the golden-main merge train from a clean `main` base and converges the currently mergeable PR set into one replacement branch. This branch absorbs: - #22296 - #22279 - #22281 - #22282 - #22283 - #22284 - #22285 - #22295 - #22297 - #22286 - #22291 - #22280 - #22277 - unique non-conflicting surfaces from #22241 - the admissibility/CACert/failure-demo runtime lane from #22314 This branch supersedes: - #22298 as the contaminated/conflicting convergence branch - #22277 as a standalone merge vehicle - #22241 as the broad mixed-purpose convergence vehicle once remaining review is complete - #22314 as the standalone admissibility lane now folded into the golden path This branch intentionally excludes: - #22292 because it targets `merge-surge/staging`, not `main` ## Conflict policy used while absorbing #22241 When merging `#22241` on top of the cleaned train, the following files conflicted and were resolved in favor of the current train versions so the newer focused CI/governance repairs remain authoritative: - `.github/ci/required-checks.json` - `.github/workflows/drift-sentinel.yml` - `.github/workflows/pr-gate.yml` - `docs/ci/REQUIRED_CHECKS_POLICY.yml` - `pnpm-lock.yaml` - `scripts/ci/check_branch_protection_drift.mjs` - `scripts/ci/validate_workflows.mjs` All other `#22241` changes merged on top of the train. ## Mapping Change Summary This convergence branch updates workflow, schema, and governance contracts that control merge eligibility, admissibility evidence, and deterministic trust artifacts. ## Diff - Added admissibility/evidence/CACert surfaces including `packages/evidence/schemas/decision_trace.schema.json` - Tightened golden-lane workflow policy and drift handling in `.github/workflows/_policy-enforcer.yml`, `.github/workflows/execution-graph-reconciliation.yml`, `.github/workflows/post-ga-hardening-enforcement.yml`, `.github/workflows/merge-surge.yml`, `.github/workflows/control-plane-drift.yml` - Realigned governance state in `governance/pilot-ci-policy.json` and `governance/branch-protection.json` - Repaired deterministic reconciliation verification in `scripts/ci/verify_execution_graph_reconciliation.mjs` and `scripts/ci/drift-sentinel.mjs` ## Justification The repo needed one mergeable replacement lane that restores deterministic governance checks, folds the admissibility implementation into the golden path, and suppresses broken optional PR workflows that were blocking convergence without being canonical required checks. ## Impact - Canonical pilot checks remain `pr-gate / gate` and `drift-sentinel / enforce` - Merge-train branches no longer fail ordinary small-PR enforcement gates by construction - Optional broken workflows are narrowed to their owned surfaces so they stop contaminating this convergence lane and the immediate post-merge main push - Execution-graph reconciliation now accepts the repo’s canonical snake_case trust bundle fields ## Rollback Plan Revert commit `ce32b96c0f` from `merge-train/golden-main-20260331-final`, then rerun the prior golden-lane checks and restore the previous PR body. ## Backfill Plan After the lane is green, backfill the same workflow scoping and governance-contract repairs into any surviving PRs that still touch `.github/workflows/**` or governance surfaces, then close superseded PRs against `#22309`. ## Validation Evidence Local validation completed: - `node scripts/ci/drift-sentinel.mjs` - `ruby -e 'require "yaml"; ... YAML.load_file(...)'` over all edited workflow files - `jq . governance/pilot-ci-policy.json` - `jq . governance/branch-protection.json` - merge-marker scan over all edited files returned clean ## Notes - Live GitHub PR checks on the open PR set are being converged through this single branch instead of salvaging each broken lane independently. - I did not run the full local verification matrix in this session; this PR is intended to give the repo one clean convergence lane for CI and human review. - After this PR lands, the absorbed PRs should be closed as superseded. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Bot <bot@summit.ai> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gemini CLI <gemini-cli@google.com>
Owner
Author
|
Superseded by #22309, which is now merged into main. |
auto-merge was automatically disabled
March 31, 2026 20:10
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
skills/summit/withREADME.mdthat enumerates the pack contents.atomic-pr-planner,ga-gate-reviewer,pilot-proof-pack-writer,closed-pr-rehydrator, andtrust-claim-auditor(files underskills/summit/*).{"agent":"antigravity","confidence":0.95,"change_type":"docs/skill-config","skills":["atomic-pr-planner","ga-gate-reviewer","pilot-proof-pack-writer","closed-pr-rehydrator","trust-claim-auditor"]}
Testing
skills/summit/files were performed and verified.Codex Task
Summary by CodeRabbit