fix: converge governance gates and cognitive security contracts#22319
Closed
BrianCLong wants to merge 28 commits intomainfrom
Closed
fix: converge governance gates and cognitive security contracts#22319BrianCLong wants to merge 28 commits intomainfrom
BrianCLong wants to merge 28 commits intomainfrom
Conversation
added 28 commits
March 31, 2026 12:23
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Important Review skippedToo many files! This PR contains 185 files, which is 35 over the limit of 150. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (185)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb4644cc36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+23
to
+26
| "python3", | ||
| [ | ||
| "-c", | ||
| "import json, sys, yaml; json.dump(yaml.load(sys.stdin.read(), Loader=yaml.BaseLoader), sys.stdout)", |
There was a problem hiding this comment.
loadYaml now shells out to python3 and imports yaml, but the workflows that call this script (pr-gate and ci-guard) do not install PyYAML before execution. On runners/images where python3-yaml is absent (common on self-hosted/minimal environments), this check fails before any contract validation runs, turning required-check evaluation into an environment-dependent failure. Please either parse YAML in Node again (as before) or explicitly install/pin the Python dependency in the invoking workflows.
Useful? React with 👍 / 👎.
Comment on lines
+51
to
+54
| {"context": "ci-guard / attestation-bundle-verifier"}, | ||
| {"context": "merge-surge / merge-queue"}, | ||
| {"context": "merge-surge / pr-fast"}, | ||
| {"context": "security-gates / gate"} |
There was a problem hiding this comment.
This branch-protection payload now requires only four contexts and omits pr-gate / gate, even though the same commit defines pr-gate / gate as canonical in required-check policy files. Running this script will configure branch protection with a weaker required-check set than policy, creating governance drift and allowing merges without the canonical PR gate. Add {"context": "pr-gate / gate"} to keep enforcement aligned.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes closed #22298. Continuing governance and CI convergence on the live branch tip. Branch-triggered workflow runs on fix/golden-main-governance-convergence-20260331 are the authoritative signal while checks settle on the new PR object.