Skip to content

check for ACTIVE session id when doing passwordless authentication #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gord5500 merged 5 commits into from
May 12, 2026
Merged

check for ACTIVE session id when doing passwordless authentication #524

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1d9d72a
check for ACTIVE session id when doing passwordless authentication
gord5500 May 12, 2026
40b0c79
reword
gord5500 May 12, 2026
4bab9b4
generic fail message
gord5500 May 12, 2026
ffe67b8
Auto format check_for_active_session_id_when_passwordless (#528)
github-actions[bot] May 12, 2026
d913b6f
Merge branch 'main' into check_for_active_session_id_when_passwordless
gord5500 May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/D2L.Bmx/Okta/Models/OktaSession.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ internal record OktaSession(
string Id,
string Login,
string UserId,
string Status,
DateTimeOffset CreatedAt,
DateTimeOffset ExpiresAt
);
7 changes: 7 additions & 0 deletions src/D2L.Bmx/OktaAuthenticator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,13 @@ string browserPath

var oktaAuthenticatedClient = oktaClientFactory.CreateAuthenticatedClient( orgUrl, sessionId );
var oktaSession = await oktaAuthenticatedClient.GetCurrentOktaSessionAsync();
if( oktaSession.Status != "ACTIVE" ) {
if( BmxEnvironment.IsDebug ) {
messageWriter.WriteWarning( "Okta passwordless authentication failed" );
}
return null;
}

string sessionLogin = oktaSession.Login.Split( "@" )[0];
string providedLogin = user.Split( "@" )[0];
if( !sessionLogin.Equals( providedLogin, StringComparison.OrdinalIgnoreCase ) ) {
Expand Down
Loading