GAUD-10312 - No arrows when divider collapsed - #7341
Conversation
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
dlockhart
left a comment
dlockhart
left a comment
There was a problem hiding this comment.
Much prefer this behaviour!
There was a problem hiding this comment.
These tests no longer provide value, as there's nothing to hover.
| if (this.#clickedArrow) return; // Arrows don't support dragging | ||
|
|
||
| const clickedArrow = path.find(el => el.classList?.contains('divider-arrow')); | ||
| if (clickedArrow) { |
There was a problem hiding this comment.
Copied from other PR for posterity:
This code moving into the click handler above fixes an eventual bug that would have come up with overlay. It's the same issue the drawer would have had - if we move the divider before the click happens, it'll click what's behind it. I thought this was only an issue with the drawer handle, but it also happens to the arrows in overlay mode, where clicking the overlay closes the drawer.
Even if we don't want that to happen (I need to ask design), it's just better and will likely save us from some other bug in the future.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
🎉 This PR is included in version 3.287.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
Alternative to #7334, where we don't render an arrow at all when the divider is collapsed, because the divider handle indicates opening direction already.
vdiff report here.