feat(mic): add runtime-configurable microphone pins to brucePins.conf#2319
Draft
pfefferle wants to merge 1 commit intoBruceDevices:devfrom
Draft
feat(mic): add runtime-configurable microphone pins to brucePins.conf#2319pfefferle wants to merge 1 commit intoBruceDevices:devfrom
pfefferle wants to merge 1 commit intoBruceDevices:devfrom
Conversation
Closes BruceDevices#2281 - Add micClk and micData fields to BruceConfigPins with defaults from the board's compile-time PIN_CLK/PIN_DATA values - Serialize/deserialize mic pins in brucePins.conf JSON - Add setMicClkPin/setMicDataPin setter methods - Add "Mic Pins" menu entry in Dev Mode for CLK and DATA pin selection - Update mic.cpp to read pins from bruceConfigPins at runtime instead of using compile-time macros directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
micClkandmicDatafields toBruceConfigPins, defaulting to the board's compile-timePIN_CLK/PIN_DATAvalues/brucePins.confJSONmic.cppto read pins frombruceConfigPinsat runtime instead of compile-time macrosCloses #2281
Test plan