Skip to content

fix: resolve HID descriptor validation failures on Windows #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dlmiller90 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: resolve HID descriptor validation failures on Windows #2351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .vs/VSWorkspaceState.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"ExpandedNodes": [
""
],
"PreviewInSolutionExplorer": false
}
Binary file added .vs/firmware-bruce.slnx/FileContentIndex/86a2a2a8-207a-438d-9380-fe51cb081ac6.vsidx
View file
Open in desktop
Binary file not shown.
Binary file added .vs/firmware-bruce.slnx/FileContentIndex/f61f9d04-26e6-4adf-a42a-4651e90c499b.vsidx
View file
Open in desktop
Binary file not shown.
Binary file added .vs/firmware-bruce.slnx/v18/.wsuo
View file
Open in desktop
Binary file not shown.
12 changes: 12 additions & 0 deletions .vs/firmware-bruce.slnx/v18/DocumentLayout.backup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"Version": 1,
"WorkspaceRootPath": "C:\\Users\\Dontay\\firmware-bruce\\",
"Documents": [],
"DocumentGroupContainers": [
{
"Orientation": 0,
"VerticalTabListWidth": 256,
"DocumentGroups": []
}
]
}
12 changes: 12 additions & 0 deletions .vs/firmware-bruce.slnx/v18/DocumentLayout.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"Version": 1,
"WorkspaceRootPath": "C:\\Users\\Dontay\\firmware-bruce\\",
"Documents": [],
"DocumentGroupContainers": [
{
"Orientation": 0,
"VerticalTabListWidth": 256,
"DocumentGroups": []
}
]
}
Binary file added .vs/firmware-bruce/v18/workspaceFileList.bin
View file
Open in desktop
Binary file not shown.
Binary file added .vs/slnx.sqlite
View file
Open in desktop
Binary file not shown.
2 changes: 2 additions & 0 deletions boards/lilygo-t-embed-cc1101/lilygo-t-embed-cc1101.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ build_flags =
-O2
-DMIC_SPM1423
-DCORE_DEBUG_LEVEL=1
-DARDUINO_USB_MODE=0
-DARDUINO_USB_CDC_ON_BOOT=0
Comment on lines +13 to +14
Copy link
Copy Markdown
Member

@bmorcelli bmorcelli Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem here is that it kills the serial monitor, and serial commands with it..

Maybe it is worth a trial resetting the USB stack and configure it as needed in a lower level, like I did here


-DRF_TX_PINS='{{"Pin 43", 43}, {"Pin 44", 44}}'
-DRF_RX_PINS='{{"Pin 43", 43}, {"Pin 44", 44}}'
Expand Down
3 changes: 2 additions & 1 deletion lib/Bad_Usb_Lib/USBHIDKeyboard.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ static const uint8_t report_descriptor[] = {
};

USBHIDKeyboard::USBHIDKeyboard()
: hid(HID_ITF_PROTOCOL_KEYBOARD), _asciimap(KeyboardLayout_en_US), shiftKeyReports(false),
: hid(HID_ITF_PROTOCOL_NONE), _asciimap(KeyboardLayout_en_US), shiftKeyReports(false),
_cacheValid(false) {
static bool initialized = false;
if (!initialized) {
Expand Down Expand Up @@ -254,3 +254,4 @@ void USBHIDKeyboard::_buildShiftCache() {
}

#endif /* CONFIG_TINYUSB_HID_ENABLED */

11 changes: 6 additions & 5 deletions platformio.ini
View file
Open in desktop
Copy link
Copy Markdown
Member

@bmorcelli bmorcelli Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don´t need to change this file..

and remove all the .vs folder, or add it into .gitignore

Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,10 @@

[platformio]
default_envs =
;m5stack-cardputer

;m5stack-cardputer
;m5stack-sticks3
m5stack-cplus2
;m5stack-cplus2
;m5stack-cplus1_1
;LAUNCHER_m5stack-cplus1_1
;m5stack-core2
Expand All @@ -33,7 +34,7 @@ default_envs =
;LAUNCHER_CYD-2432W328C
;LAUNCHER_CYD-3248S035R
;LAUNCHER_CYD-3248S035C
;lilygo-t-embed-cc1101
lilygo-t-embed-cc1101
;lilygo-t-embed
;lilygo-t-deck
;lilygo-t-watch-s3
Expand Down Expand Up @@ -83,8 +84,8 @@ platform = https://github.com/pioarduino/platform-espressif32/releases/download/
;https://github.com/pioarduino/platform-espressif32/releases/download/55.03.34/platform-espressif32.zip ; Arduino 3.3.4
;https://github.com/pioarduino/platform-espressif32/releases/download/stable/platform-espressif32.zip ; Last Version
platform_packages =
framework-arduinoespressif32-libs @ https://github.com/bmorcelli/esp32-arduino-lib-builder/releases/download/idf-release_v5.5/bruce_esp32-arduino-libs-20260123-153546.zip ; Arduino 3.3.6
;framework-arduinoespressif32-libs @ https://github.com/bmorcelli/esp32-arduino-lib-builder/releases/download/idf-release_v5.5/bruce_esp32-arduino-libs-20251205-131242.zip ; Arduino 3.3.4
;framework-arduinoespressif32-libs @ https://github.com/bmorcelli/esp32-arduino-lib-builder/releases/download/idf-release_v5.5/bruce_esp32-arduino-libs-20260123-153546.zip ; Arduino 3.3.6
framework-arduinoespressif32-libs @ https://github.com/bmorcelli/esp32-arduino-lib-builder/releases/download/idf-release_v5.5/bruce_esp32-arduino-libs-20251205-131242.zip ; Arduino 3.3.4
;framework-arduinoespressif32-libs @ https://github.com/bmorcelli/esp32-arduino-lib-builder/releases/download/idf-release_v5.5/esp32-arduino-libs-20250919-170356.zip ; Arduino 3.3.1

monitor_filters = esp32_exception_decoder, send_on_enter, colorize
Expand Down
2 changes: 2 additions & 0 deletions src/modules/others/u2f.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ static const uint8_t U2F_REPORT_DESCRIPTOR[] = {
0x06, 0xD0, 0xF1, // USAGE_PAGE (FIDO Alliance)
0x09, 0x01, // USAGE (U2F Authenticator Device)
0xA1, 0x01, // COLLECTION (Application)
0x85, 0x06, // REPORT_ID (6)
0x09, 0x20, // USAGE (Input Report Data)
0x15, 0x00, // LOGICAL_MINIMUM (0)
0x26, 0xFF, 0x00, // LOGICAL_MAXIMUM (255)
Expand Down Expand Up @@ -1718,3 +1719,4 @@ void u2f_setup() {
void u2f_setup() { displayError("USB HID disabled"); }

#endif