Retitle two survey sections - #127
Merged
Merged
Conversation
"Five direct questions" describes the form's shape rather than what it asks about; "Five decisions facing the next council" says the subject. "A few more, if you have time" framed a third of the questionnaire as optional filler when it carries the trade-off questions, so it becomes "Priorities and trade-offs". The second title appears in both surveys — the resident set asks the same block — and both are renamed, since leaving them apart would put two names on one section across the pair they are meant to be read against each other. Titles are denormalized onto every question in the step, so this touches 25 rows' worth of JSON and no other field. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Greptile SummaryRetitles two questionnaire sections while preserving the surveys’ existing structure and question data. The accompanying test change isolates response-seed files during parallel test execution.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| db/seeds/elections/toronto_2026_candidate_questionnaire.json | Consistently updates the denormalized titles for both affected candidate-questionnaire sections without changing other question fields. |
| db/seeds/elections/toronto_2026_city_priorities.json | Consistently renames the shared resident-survey section across all ten questions in that step. |
| test/tasks/elections_seed_test.rb | Replaces a shared seed-fixture path with a unique per-test temporary directory and guarded teardown cleanup. |
Reviews (2): Last reviewed commit: "Give each seed test its own fixture dire..." | Re-trigger Greptile
The seed tests all wrote to one fixed path, tmp/test_candidate_responses .json, while the suite runs across 14 processes. Tests raced to overwrite the file another was about to read, so a case asserting on an off-roster candidate saw a different test's payload instead. It surfaced as a wrong assertion rather than an obvious collision, and only sometimes — three green local runs said flake, CI said otherwise. The varying assertion count across runs (4947, 4950, 4953) was the tell. Dir.mktmpdir per test, removed in teardown. Repeated writes inside one test still reuse the file, which the re-seed cases depend on. Six full parallel runs now sit at 4953 assertions. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
greptile-apps
Bot
dismissed
their stale review
September 8, 2026 20:54
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two section titles, in both surveys where they appear.
"Five direct questions" described the form's shape rather than its subject. "A few more, if you have time" framed a third of the questionnaire as optional filler when it actually carries the trade-off questions.
The second title appears in both surveys — the resident set asks the same block — so both are renamed. Leaving them apart would put two names on one section across a pair meant to be read against each other. Say the word if you'd rather the live resident survey kept its old title.
Scope
Section titles are denormalized onto every question in the step, so this is 25 rows' worth of JSON across two files and no other field — verified: zero changed lines that aren't
step_title.The first pass at this escaped every non-ASCII character (
“→“), which parses identically but wrecks the file; redone withensure_ascii=False.Applied
Re-seeded locally: titles correct, and all 58 candidate responses came through still published, confirming the seed's status-preservation rule.
1295 tests, 0 failures.
Nothing poll-related is touched.