Skip to content

fix: Don't attempt to hide the window if no active status icon present#111

Closed
City-busz wants to merge 1 commit into
C0rn3j:mainfrom
City-busz:patch-3
Closed

fix: Don't attempt to hide the window if no active status icon present#111
City-busz wants to merge 1 commit into
C0rn3j:mainfrom
City-busz:patch-3

Conversation

@City-busz

Copy link
Copy Markdown

If no status icon is visible, the window cannot be restored, leaving a process running in the background. Instead of that, just exit the app on close in this case.

If no status icon is visible, the window cannot be restored,
leaving a process running in the background. Instead of that,
just exit the app on close in this case.
@C0rn3j

C0rn3j commented Jul 19, 2026

Copy link
Copy Markdown
Owner

I've done something similar in 727d3dd

First, am not sure about removing IS_UNITY - I thought Unity is dead but apparently it's revived again in Ubuntu Unity - with the added check I suppose it might be safe to remove the IS_UNITY check?

Second, I think the original PR is bad UX - user already configured what's effectively "Do not close when I press X" and the PR ends up closing on X if tray is broken - I've changed it to do nothing and log an error, which I think is better and also immediately shows that a bug has occurred, rather than having the app effectively crash without the user knowing and expecting it to be there in the background.

@City-busz

Copy link
Copy Markdown
Author

I think it would better to show a confirmation dialog like this: "Unable to hide the window to the system tray. Do you want to quit the application instead?"

@City-busz

Copy link
Copy Markdown
Author

See: #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants