fix: Don't attempt to hide the window if no active status icon present#111
fix: Don't attempt to hide the window if no active status icon present#111City-busz wants to merge 1 commit into
Conversation
If no status icon is visible, the window cannot be restored, leaving a process running in the background. Instead of that, just exit the app on close in this case.
|
I've done something similar in 727d3dd First, am not sure about removing Second, I think the original PR is bad UX - user already configured what's effectively "Do not close when I press X" and the PR ends up closing on X if tray is broken - I've changed it to do nothing and log an error, which I think is better and also immediately shows that a bug has occurred, rather than having the app effectively crash without the user knowing and expecting it to be there in the background. |
|
I think it would better to show a confirmation dialog like this: "Unable to hide the window to the system tray. Do you want to quit the application instead?" |
|
See: #114 |
If no status icon is visible, the window cannot be restored, leaving a process running in the background. Instead of that, just exit the app on close in this case.