feat(JumpEffect): add image mode - #8793
Merged
Merged
Conversation
- Added new "Image" jump effect mode. - Refactored `drawSquareTexture` to support `AnchorPoint` for zero-allocation alignment across 9 pivot points. - Modularized Jump Effect architecture to allow seamless adding of new effect modes.
…time - Add drawSquareTextureGradient for smooth radial texture shading - Refactor lifetime config to range (separated animTime and total lifetime) - Smooth out color fade transition based on the new lifetime range - Add jump circle texture with LiquidBounce logo
Contributor
|
Thanks for the PR, the in-game shots look great. A couple of things from a first pass (humans will do the real review):
Related earlier work on this module: #8240. 🤖 Automated support reply — a human maintainer will review if this doesn't help. |
MukjepScarlet
requested changes
Aug 7, 2026
Contributor
Author
|
I didn't expect ghost TargetRender to be fine as long as Particles were intact |
MukjepScarlet
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New jump circles
without logo:
with logo:
in game: