Skip to content

Add message translation caching #8797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vespe-r wants to merge 1 commit into
base: nextgen
Choose a base branch
from
+21 −0
Open

Add message translation caching #8797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/main/kotlin/net/ccbluex/liquidbounce/features/global/GlobalSettingsAutoTranslate.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,36 @@ import net.ccbluex.liquidbounce.api.thirdparty.translator.TranslatorApi
import net.ccbluex.liquidbounce.api.thirdparty.translator.providers.GoogleTranslateApi
import net.ccbluex.liquidbounce.config.types.group.ValueGroup
import net.ccbluex.liquidbounce.event.EventListener
import net.ccbluex.liquidbounce.utils.collection.LruCache

private data class TranslationKey(val sourceLanguage: String, val targetLanguage: String, val text: String)

object GlobalSettingsAutoTranslate : ValueGroup(name = "AutoTranslate"), TranslatorApi, EventListener {

private val cache = LruCache<TranslationKey, TranslationResult>(10_000)

@MukjepScarlet MukjepScarlet Aug 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10_000 is incorrect. Should be power of 2. You can probably use Guava's cache.

private val providers = modes(this, "Provider", 0) {
arrayOf(
GoogleTranslateApi(it)
)
}

override suspend fun translate(
sourceLanguage: TranslateLanguage,
targetLanguage: TranslateLanguage,
text: String
): TranslationResult {
val key = TranslationKey(sourceLanguage.literal, targetLanguage.literal, text)
cache[key]?.let { return it }

val result = super.translate(sourceLanguage, targetLanguage, text)

if (result.isValid) {
cache.put(key, result)
}

return result
}

override suspend fun translateInternal(
sourceLanguage: TranslateLanguage,
targetLanguage: TranslateLanguage,
Expand Down