Added configs to be part of Caliper metadata#209
Conversation
|
@rfhaque : May you please review this PR? The goal is to add missing configs/params to Caliper metadata using Aidak. Please advise if there’re any changes needed. |
82e4c1b to
eb5daad
Compare
|
@amroakmal Please resolve conflicts. |
b927012 to
6494bad
Compare
|
@vladotomov : Thanks, I’ve resolved the conflicts and addressed the comments. One point I wanted to clarify: I made these changes in main because, outside of it, I don’t have access to the variables needed to log the configuration values to Caliper. The current approach addresses your feedback, although it makes the main function more simpler/shorter and more readable, but the new function now takes several parameters. I also considered an alternative approach of grouping these variables into a struct, but that would require more extensive changes than what I’ve done here. Please let me know your thoughts and which approach you would prefer. Thanks. |
|
@amroakmal this looks good, thank you. |
No description provided.