Skip to content

Added configs to be part of Caliper metadata#209

Merged
vladotomov merged 2 commits intoCEED:masterfrom
amroakmal:add-configs-to-metadata
Apr 3, 2026
Merged

Added configs to be part of Caliper metadata#209
vladotomov merged 2 commits intoCEED:masterfrom
amroakmal:add-configs-to-metadata

Conversation

@amroakmal
Copy link
Copy Markdown

No description provided.

@amroakmal
Copy link
Copy Markdown
Author

@rfhaque : May you please review this PR? The goal is to add missing configs/params to Caliper metadata using Aidak. Please advise if there’re any changes needed.

@amroakmal amroakmal force-pushed the add-configs-to-metadata branch 4 times, most recently from 82e4c1b to eb5daad Compare March 19, 2026 21:37
Comment thread laghos.cpp Outdated
Copy link
Copy Markdown

@pearce8 pearce8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address David's comment

@amroakmal amroakmal requested review from daboehme and pearce8 March 23, 2026 18:38
@vladotomov
Copy link
Copy Markdown
Member

vladotomov commented Mar 29, 2026

@amroakmal Please resolve conflicts.
Also, 50 lines in the main function is too much, can you pull those into a separate function.

@amroakmal amroakmal force-pushed the add-configs-to-metadata branch from b927012 to 6494bad Compare March 31, 2026 05:53
@amroakmal
Copy link
Copy Markdown
Author

@vladotomov : Thanks, I’ve resolved the conflicts and addressed the comments.

One point I wanted to clarify: I made these changes in main because, outside of it, I don’t have access to the variables needed to log the configuration values to Caliper. The current approach addresses your feedback, although it makes the main function more simpler/shorter and more readable, but the new function now takes several parameters.

I also considered an alternative approach of grouping these variables into a struct, but that would require more extensive changes than what I’ve done here.

Please let me know your thoughts and which approach you would prefer. Thanks.

@vladotomov
Copy link
Copy Markdown
Member

@amroakmal this looks good, thank you.

@vladotomov vladotomov merged commit 206e617 into CEED:master Apr 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants