fix(demo-ci): create integration branch, add workflow_dispatch ref input, re-target child PRs - #2146
Merged
Conversation
…put, re-target child PRs - Create fix/demo-ci branch off main HEAD (ISSUE-2139 AC-1) - Re-target PR #2127 from main to fix/demo-ci (ISSUE-2139 AC-2) - Add fix/demo-ci to pull_request and push branches triggers so child fix PRs get Demo Integration CI gate against the integration branch (DEMOCI-09-002) - Add workflow_dispatch ref input (type: string) so full 9-scenario suite can be run against any branch without a dummy PR to main (DEMOCI-09-001) - Update all three actions/checkout steps to use ref: ${{ inputs.ref || github.ref }} — transparent passthrough on normal PR/push events, uses inputs.ref on manual dispatches - Add cleanup issue #2144 reference in inline branch comments - Add DEMOCI-09 spec group to specs/demo-ci.yaml (version 1.6.0) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements CONCERN-2137's coordinated integration branch strategy so multiple
demo-CI bug fixes can land on
fix/demo-cibefore any reachesmain.Changes
fix/demo-cibranch created off currentmainHEAD (AC-1).main→fix/demo-ci(AC-2). Issues Bug: fcv-reject invariant 15 fails — vfd_state == 'VFd' (fix_ready) never observed #2121,Bug: EmitValidateReportActivity crashes with 'NoneType' has no attribute 'model_dump' on invite-path vendor triage #2134, Bug: fcv demo fails with CLP-08-005 on finder — scope of #2120 fix unclear #2135 already carried "target
fix/demo-ci" warnings in their bodies (AC-3)..github/workflows/demo-integration.yml(AC-4):pull_requestandpushtriggers extended to coverfix/demo-cisoeach child fix PR gets the same Demo Integration gate against the integration
branch (DEMOCI-09-002).
workflow_dispatchgains an optionalrefinput (type: string) so thefull 9-scenario suite can be run against the integration branch without
opening a dummy PR to
main(DEMOCI-09-001).actions/checkoutsteps updated toref: ${{ inputs.ref || github.ref }};on normal PR/push events the expression transparently falls through to
github.ref.# fix/demo-ci: temporary — remove when merged (#2144)comments addedat both
branches:arrays as a durable reminder.specs/demo-ci.yamlbumped to 1.6.0; new DEMOCI-09 group added withDEMOCI-09-001 (ref input spec) and DEMOCI-09-002 (integration branch CI spec).
fix/demo-cientries after theintegration branch merges.
AC status
fix/demo-cicreated via GitHub API offmainfix/demo-ciworkflow_dispatchrefinput wired in all three checkout stepsfix/demo-ciand full suite is greenfix/demo-ciVerification
python3 -c "import yaml; yaml.safe_load(...)"