fix(franca_to_ifex): remove undefined log() call and dead code after raise - #163
Open
SoundMatt wants to merge 1 commit into
Open
fix(franca_to_ifex): remove undefined log() call and dead code after raise#163SoundMatt wants to merge 1 commit into
SoundMatt wants to merge 1 commit into
Conversation
…raise The `__main__` block called `log(...)` which is not defined in this module, causing a `NameError` on FileNotFoundError. Replace with `print()`. The dead-code `log(...)` after `raise(e)` in the general except clause is also removed, and the bare `raise` form is used so the original traceback is preserved. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
Collaborator
|
Logging strategy and methods are currently a bit inconsistent. I will defer this one and aim for a more comprehensive overhaul of the logging strategy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
__main__block has two bugs in its exception handlers:log("ERROR: File not found")—logis not defined in this module, so aFileNotFoundErrorwould immediately be followed by aNameError, hiding the real error. Replaced withprint().raise(e)followed bylog(...)— thelogcall is unreachable dead code. Simplified to a bareraisewhich also preserves the original traceback.