Skip to content

fix(JinjaSetup): remove unreachable return None; use Exception not BaseException #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SoundMatt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(JinjaSetup): remove unreachable return None; use Exception not BaseException #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ifex/output_filters/JinjaSetup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from typing import Dict, Any

# Exception:
class GeneratorError(BaseException):
class GeneratorError(Exception):
def __init__(self, m):
self.msg = m

Expand Down Expand Up @@ -145,8 +145,6 @@ def render_node(self, node):
else:
return template.render({"item" : node})

return None


# wrapper over jinja2 to export environment.
def set_template_env(self, **kwargs):
Expand Down