fix(ast_utils): use field.type and field.name in prune function - #181
Open
SoundMatt wants to merge 1 commit into
Open
fix(ast_utils): use field.type and field.name in prune function#181SoundMatt wants to merge 1 commit into
SoundMatt wants to merge 1 commit into
Conversation
Two bugs in the `prune` function: 1. `is_optional(field)` passes the `dataclasses.Field` object instead of its type hint; should be `is_optional(field.type)`. 2. `setattr(node, field, None)` passes the `Field` object as the attribute name instead of the string name; should be `setattr(node, field.name, None)`. Both would raise a `TypeError` / `AttributeError` whenever `prune` was called on a matching node. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in the
prunefunction body:is_optional(field)—fieldis adataclasses.Fieldobject, butis_optionalexpects a type indicator (e.g.Optional[str]). Passfield.typeinstead.setattr(node, field, None)—fieldis again theFieldobject, not a string attribute name. Passfield.nameinstead.Both would raise a
TypeErrororAttributeErrorat runtime wheneverprunewas called on a node that matched the given field values.