Skip to content

fix(rule_translator): correct guard logic for None / all-None-list values #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SoundMatt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(rule_translator): correct guard logic for None / all-None-list values #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ifex/transformers/rule_translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ def transform(mapping_table, input_obj):
value = transform_value_common(mapping_table, getattr_value(input_obj, input_attr), field_transform)

# Set attribute unless the result was None (or sometimes due to list handling, a *list* of None values)
if value != None and (isinstance(value, list) and not all([x == None for x in value])):
if value is not None and (not isinstance(value, list) or not all(x is None for x in value)):
set_attr(attributes, output_attr, value)

# Mark this attribute as handled
Expand Down