Conversation
Co-authored-by: riderx <4084527+riderx@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e95932406
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!toBack) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Restore system UI before returning on non-toBack start
This early return skips cleanup when a previous session already locked system bars for toBack=true. In a valid flow like start({ force: true, toBack: false }), the old session is stopped without calling stop(), so originalStatusBarColor/originalNavigationBarColor remain cached and the status/navigation bars stay forced to opaque colors (and contrast disabled on Android Q+) even though the new session is not toBack; this leaves the app UI in an incorrect state until a later explicit restore path runs.
Useful? React with 👍 / 👎.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.