v2 public-props API review (#342): naming consistency pass

[CarlosNZ]

Works through the #342 public-props review. Since v2 is unreleased, these are done now. Each item was decided on its merits — some renamed, several deliberately kept where the "inconsistency" turned out to be load-bearing.

Changed

#	Change	Notes
1	allowClipboard → showClipboardButton	It's a display toggle, not a capability gate (can't prevent copying) — moved into the show* family
2	onChange — no change	Kept the name + compulsory => ValueData return (already enforced at compile time); rename withdrawn
3	'when-closed' → 'when-collapsed'	showCollectionCount literals — unifies vocabulary on "collapse"
5	CustomSelect → Select (CustomSelectProps → SelectProps)	Bare PascalCase, off the custom* config-family prefix
7	updateSuccessful → updateSuccess	Noun/noun parallel with updateError; keeps the pervasive "error" vocabulary
9	Removed the custom-component error-reporter prop	Components reject invalid input by throwing from fromStandardType — kills the onError name clash entirely (no in-repo callers)
10	CustomNodeDefinition's U generic now binds wrapperProps	Genuine type bug fix (was Record<string, unknown>); compile-time regression guard added
11	setIsEditingKey → startEditingKey	It's a zero-arg command, not a React Dispatch — the setIs* name misled
12	handleKeyPress → onKeyDown	Off React's deprecated "keyPress" name; both public props (CustomComponentProps + AutogrowTextArea)
13	Dropped redundant data from CustomComponentProps	Use value (live) / nodeData.value (committed); data duplicated the latter and was typed unknown
—	README ↔ types drift (a–e)	Fixed DefaultValueFunction, TypeOptions, the insertAtTop type-cell typo + a stray table cell, the moved link component, and the stale onEditEvent row

Kept (won't-fix), with rationale

• More sophisticated theming #4 collapse prop — collision with editorRef.collapse() is cross-namespace (low confusion), and every natural replacement (defaultCollapse/initialCollapse) would mislead: React's default*/initial* convention means "uncontrolled, set-once", but this prop is reactive.
• Localisation #6 allowTypeSelection — not the lone outlier it looks: it's interaction-named like allowDrag. Renaming only it would be a half-measure, and "Selection" is accurate (it takes TypeOptions).
• Better icons #8 bare delete/move in EditEvent — the bare name signals an atomic single-event op; commit* would imply a start*/submit* lifecycle that doesn't exist for instant ops. (Already documented in the type + README.)
• Performance improvements #14 EnumDefinition.enum — it's a self-documenting type-tag inside allowTypeSelection arrays (among bare type strings); name would read as a generic object and lose that signal.
• (f) arrayIndexStart 0 | 1 — deliberately documented narrower than its number type.

Notes

• Most renames are breaking. The ones a v1 consumer must act on are in the migration guide (§6 clipboard split, §11 custom-node fields incl. the error-reporter removal / startEditingKey / onKeyDown / value); the v2-dev-only renames update their existing changesets in place. Changesets are included/updated throughout.
• tsc, lint, the full test suite (488 passing), and the @json-edit-react/components typecheck are green on every commit.

🤖 Generated with Claude Code

[github-actions]

Bundle size impact

json-edit-react

Format	Base raw	PR raw	Δ raw	Base gzip	PR gzip	Δ gzip
esm	55.70 KB	55.68 KB	🟢 -14 B (-0.02%)	20.00 KB	19.98 KB	🟢 -22 B (-0.11%)
cjs	57.20 KB	57.19 KB	🟢 -14 B (-0.02%)	20.09 KB	20.07 KB	🟢 -22 B (-0.11%)

@json-edit-react/components

Format	Base raw	PR raw	Δ raw	Base gzip	PR gzip	Δ gzip
esm	13.75 KB	13.74 KB	🟢 -10 B (-0.07%)	4.67 KB	4.67 KB	🟢 -3 B (-0.06%)
cjs	14.45 KB	14.44 KB	🟢 -10 B (-0.07%)	4.54 KB	4.53 KB	🟢 -8 B (-0.17%)

_{Measured from build/index.{cjs,esm}.js. Gzip at level 9.}