Skip to content

Document logger parameter in TwigFactory for future use #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArnaudLigny merged 4 commits into from
Jan 19, 2026
Merged

Document logger parameter in TwigFactory for future use #2287

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d594d87
Initial plan
Copilot Jan 19, 2026
beb5bff
Remove unused logger parameter from TwigFactory
Copilot Jan 19, 2026
c335059
Document logger parameter for future use
Copilot Jan 19, 2026
c9769d0
Apply fixes from StyleCI (#2288)
ArnaudLigny Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Renderer/Twig/TwigFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,13 @@
class TwigFactory
{
private Config $config;

/**
* Logger instance for future use.
* Reserved for consistency with other factory patterns in the codebase.
Comment thread
ArnaudLigny marked this conversation as resolved.
*/
private LoggerInterface $logger;

private Builder $builder;

public function __construct(
Expand Down