Skip to content

Hover popup only on first line (AST-153103) #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cx-aniket-shinde wants to merge 1 commit into
base: feature/AST-109633-ui-manager-changes
Choose a base branch
from
Open

Hover popup only on first line (AST-153103) #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions ...visual-studio-extension/CxExtension/CxAssist/Core/Markers/CxAssistAsyncQuickInfoSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,43 @@ public async Task<QuickInfoItem> GetQuickInfoItemAsync(IAsyncQuickInfoSession se
if (issuesOnly.Count == 0)
return null;

// If any vulnerability spans multiple lines: only show popover on the first line
var hasMultiLineVuln = issuesOnly.Any(v =>
(v.Locations != null && v.Locations.Count > 1) ||
(v.EndLineNumber > 0 && v.EndLineNumber > v.LineNumber));

if (hasMultiLineVuln)
{
foreach (var vuln in issuesOnly)
{
// Check if this specific vulnerability is multi-line
bool isMultiLine = (vuln.Locations != null && vuln.Locations.Count > 1) ||
(vuln.EndLineNumber > 0 && vuln.EndLineNumber > vuln.LineNumber);

if (isMultiLine)
{
// Determine the actual first line of this multi-line vulnerability
int actualFirstLine = vuln.LineNumber;

if (vuln.Locations != null && vuln.Locations.Count > 0)
{
var firstLocation = vuln.Locations.OrderBy(l => l.Line).FirstOrDefault();
if (firstLocation != null)
{
actualFirstLine = firstLocation.Line;
}
}

// Only show popover one line prior to the actual first line
int targetLine = actualFirstLine - 1;
if (lineNumber != targetLine)
{
return null;
}
}
}
}

// Only one of our sources (per session) should contribute; avoid duplicate blocks when multiple subject buffers exist.
lock (_sessionLock)
{
Expand Down