Skip to content

phpcs_ignore_paths key should be an optional array, not required.#249

Merged
apotek merged 1 commit into5.xfrom
106-require-custom-code-paths
Mar 2, 2026
Merged

phpcs_ignore_paths key should be an optional array, not required.#249
apotek merged 1 commit into5.xfrom
106-require-custom-code-paths

Conversation

@apotek
Copy link
Copy Markdown
Contributor

@apotek apotek commented Mar 2, 2026

Description

A missing phpcs_ignore_paths configuration key throws an exception. It should be an optional configuration key. This fixes that.

Motivation / Context

Resolves #106

Testing Instructions / How This Has Been Tested

Run phpcs (linting tasks) in your project without the phpcs_ignore_paths key.

@apotek apotek self-assigned this Mar 2, 2026
@apotek apotek requested a review from agarzola March 2, 2026 15:15
Copy link
Copy Markdown
Member

@agarzola agarzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on a project where I temporarily deleted phpcs_ignore_paths and it worked like a charm!

@apotek apotek merged commit fd90c68 into 5.x Mar 2, 2026
7 checks passed
@apotek apotek deleted the 106-require-custom-code-paths branch March 2, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHPCS fails when phpcs_ignore_paths is not set.

2 participants