Skip to content

Build workspace packages after their devDependencies - #18

Merged
jzongker merged 1 commit into
mainfrom
fix/wave-lint-tests
Aug 17, 2026
Merged

Build workspace packages after their devDependencies#18
jzongker merged 1 commit into
mainfrom
fix/wave-lint-tests

Conversation

@jzongker

Copy link
Copy Markdown
Contributor

Summary

  • Switch the root build script from --topological to --topological-dev so @churchapps/helpers (a devDependency of apihelper/apphelper) is compiled before those packages. This unblocks CI's "Build all packages (topological)" step, which has been failing with TS2307: Cannot find module '@churchapps/helpers' since before the 2026-08-16 wave.
  • Wrap PUBLIC_CONTENT_TYPE_PREFIXES in apihelper/src/helpers/S3UploadPolicy.ts so the 8-item array satisfies array-bracket-newline (wave-introduced lint error from Constrain S3 upload ACL and types #16).

Test plan

  • Fresh workspace build (topological-dev) from empty dist folders — pass
  • apihelper eslint on src/ — 0 errors
  • Root lint (lint:check foreach) — pass
  • workspace @churchapps/apphelper test — 5 files / 32 tests
  • workspace @churchapps/integration-sdk test — 4 files / 26 tests
  • apihelper tests (incl. S3 policy + disk path guards) — 33 pass
  • helpers tests — 53 pass

Do not merge from this PR unless you intend to; this is the lint/CI-build fix only.

CI topological build compiled apihelper before helpers/dist existed; --topological-dev honors the helpers devDependency, and the S3 allowlist is wrapped to satisfy array-bracket-newline.
@jzongker
jzongker merged commit 5df644e into main Aug 17, 2026
1 check passed
@jzongker
jzongker deleted the fix/wave-lint-tests branch August 17, 2026 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant