Fix Google Drive root browse returning an empty list - #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browsing Google Drive returned nothing on production (ChurchAppsSupport #944).
Root cause
GoogleDriveProvider.listFilessentincludeItemsFromAllDrives=truealongside a'root' in parentsquery.rootis an alias that only resolves inside the user's own corpus, so pairing it with an all-drives search made Google reject the request.ApiHelper.apiRequestturned the non-OK response intonull,listFilesbroke out of its pagination loop with no entries, andbrowsereturned[]— an empty folder rather than an error.Changes
listFiles: keepsupportsAllDrives=true, dropincludeItemsFromAllDrives, and setcorpora=user. Ordering (folder,name_natural) is unchanged.ApiHelper.apiRequest: on a non-OK response, log the response body truncated to 500 chars so the provider's actual reason shows up in logs instead of just the status code.supportsAllDrives=true+corpora=userand noincludeItemsFromAllDrives, and that a failed fetch yields[]. Existing audio/octet-stream coverage is untouched.All 34 content-providers tests pass.