Show SignPresenter playlist media from V2 slides - #23
Merged
Conversation
The content-messages endpoint only returns templates 1 and 3, so B1Admin listed playlists with no items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SignPresenter playlists listed in B1Admin but showed no media items.
Root cause
SignPresenterProvider.getMessagescalledGET /content/playlists/:id/messagesand skipped any message without a truthyurl. That content endpoint only returns templates 1 (image) and 3 (video), and only extractsfieldTypeimage/silentVideo, often returningurl: "". Typical playlists use other templates, so browse/getPlaylist/getInstructions came back empty.The documented player contract is
GET /v2/playlists/:id, whose messages carryslides[].type+slides[].data.url.Changes
/v2/playlists/:idand map image, video, stream, and media-file web slides toContentFile(slide.data.url→ url/downloadUrl,slide.type→ mediaType, message thumbnail, slide seconds, loop)./content/playlists/:id/messageswhen V2 is empty/missing, now usingurl || thumbnail || image./content/playlistsis unchanged. Dropbox/Drive untouched.All 40 content-providers tests pass.