ldirectord: Remove /var/lock from systemd unit#1328
Open
hrasiq wants to merge 1 commit intoClusterLabs:mainfrom
Open
ldirectord: Remove /var/lock from systemd unit#1328hrasiq wants to merge 1 commit intoClusterLabs:mainfrom
hrasiq wants to merge 1 commit intoClusterLabs:mainfrom
Conversation
The /var/lock/subsys/ directory is used in sysv init scripts, but are not necessary in systemd services. If /var/lock/subsys/ does not exist, the systemd service will fail to start due to the missing folder for the ExecStartPost command. Since these locks are not required in systemd services, we can safely remove them from the ldirectord unit file.
|
Can one of the admins verify this patch? |
|
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents-pipeline/job/PR-1328/1/input |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /var/lock/subsys/ directory is used in sysv init scripts, but are
not necessary in systemd services. If /var/lock/subsys/ does not exist,
the systemd service will fail to start due to the missing folder for the
ExecStartPost command. Since these locks are not required in systemd
services, we can safely remove them from the ldirectord unit file.