Feature: Add reload feature for trace_ra to prevent resource restarts#2147
Open
Reshma676 wants to merge 3 commits intoClusterLabs:mainfrom
Open
Feature: Add reload feature for trace_ra to prevent resource restarts#2147Reshma676 wants to merge 3 commits intoClusterLabs:mainfrom
Reshma676 wants to merge 3 commits intoClusterLabs:mainfrom
Conversation
|
Can one of the project admins check and authorise this run please: https://haci.fast.eng.rdu2.dc.redhat.com/job/resource-agents/job/resource-agents-pipeline/job/PR-2147/1/input |
Note: This implementation was developed with the assistance of Claude AI.
6d0f63c to
f68ab82
Compare
|
Can one of the project admins check and authorise this run please: https://haci.fast.eng.rdu2.dc.redhat.com/job/resource-agents/job/resource-agents-pipeline/job/PR-2147/2/input |
Based on upstream maintainer feedback, simplify the architecture by: - Removing ocf_trace_reload helper function from ocf-shellfuncs - Removing agent-specific reload functions (ip_reload, anything_reload) - Making reload action return OCF_SUCCESS directly - Changing trace_ra parameter type from integer to boolean This achieves the same zero-downtime trace configuration updates with a cleaner, more straightforward implementation. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Can one of the project admins check and authorise this run please: https://haci.fast.eng.rdu2.dc.redhat.com/job/resource-agents/job/resource-agents-pipeline/job/PR-2147/3/input |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note on AI Usage: > For full transparency, the code and architecture in this PR were developed with the assistance of the Claude AI model .
Currently, enabling trace_ra=1 forces Pacemaker to perform a full stop/start cycle on the resource. In production environments, this causes unnecessary service downtime just to enable debug logging.
This PR introduces a zero-downtime solution by leveraging the reload action:
Added a shared ocf_trace_reload function to ocf-shellfuncs.in.
Updated IPaddr2 and anything to include the trace_ra parameter, the metadata action, and the reload handler.
Tested successfully on a live RHEL 10 Pacemaker cluster. Updating the trace_ra parameter and triggering a reload successfully enables/disables the trace output while the IPaddr2 resource remains in the Started state without any downtime or transition restarts.