Skip to content

Modernize dependencies: update cffi to 2.0.0 and setuptools-golang to 2.9.0 #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jainal09 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Modernize dependencies: update cffi to 2.0.0 and setuptools-golang to 2.9.0 #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9b9449
Modernize dependencies: update cffi to 2.0.0 and setuptools-golang to…
jainal09 Mar 19, 2026
3a41b5a
Address PR feedback: use sys.executable for pip and bound cffi version
jainal09 Mar 19, 2026
dbad8b6
Add generated build artifacts to .gitignore
jainal09 Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,7 @@ pybluemonday/*.so
.DS_Store
bluemonday.o
bluemonday.so
bluemonday.c
bluemonday.h
bluemonday.cpython-*.so
.eggs
7 changes: 4 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import platform
import setuptools
import subprocess
import sys
import re

# Print out our uname for debugging purposes
Expand Down Expand Up @@ -37,7 +38,7 @@
subprocess.call(["make", "so"], env=env)

# Build the CFFI headers
subprocess.call(["pip", "install", "cffi~=1.1"], env=env)
subprocess.check_call([sys.executable, "-m", "pip", "install", "cffi>=2.0.0,<3"], env=env)
subprocess.call(["make", "ffi"], env=env)

with open("pybluemonday/__init__.py", "r", encoding="utf8") as f:
Expand Down Expand Up @@ -65,6 +66,6 @@
# I'm not sure what this value is supposed to be
build_golang={"root": "github.com/ColdHeat/pybluemonday"},
ext_modules=[setuptools.Extension("pybluemonday/bluemonday", ["bluemonday.go"])],
setup_requires=["setuptools-golang==2.7.0", "cffi~=1.1"],
install_requires=["cffi~=1.1"],
setup_requires=["setuptools-golang==2.9.0", "cffi>=2.0.0,<3"],
install_requires=["cffi>=2.0.0,<3"],
)