add(semver): remove 'v' prefix in release version#64
Open
Guts wants to merge 2 commits into
Open
Conversation
Guts
force-pushed
the
feature/support-prefix-removal
branch
from
9455d29 to
e038ab5
Compare
Guts
force-pushed
the
feature/support-prefix-removal
branch
from
e038ab5 to
611908b
Compare
Contributor
Author
|
@Colin-b is something missing in my PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
vprefix is a common pattern. In this PR, I propose to remove it on the fly when it's present to give it a chance to fill themetadata.semantic_versionattribute.I also add some minor log messages (I use the lib as a Python package and not as CLI).
qgis/qgis-plugin-ci#68
Funded by Oslandia.