Skip to content

feat: support multi-spectrum comparison in SpectraEditor#310

Open
Nicolass67 wants to merge 6 commits into
masterfrom
feat/comparison-spectra
Open

feat: support multi-spectrum comparison in SpectraEditor#310
Nicolass67 wants to merge 6 commits into
masterfrom
feat/comparison-spectra

Conversation

@Nicolass67

Copy link
Copy Markdown
Contributor

Summary

This PR adds multi-spectrum comparison support to @complat/react-spectra-editor

What this enables

  • Comparison modal workflow: the ELN passes multiple JCAMP entities; the editor loads them via MultiJcampsViewer and renders them in the multi-curve viewer (d3_multi).
  • Active spectrum selection: a graph selection panel lets users pick which curve is being edited; toolbar actions and annotations apply to that curve.
  • Per-curve state: shift, peaks, integrations, multiplicities, and threshold are tracked per spectrum, so calibration and annotations stay correct when switching between overlaid curves.
  • Layout-aware UI: toolbar controls that do not apply to the current layout (NMR, HPLC, CV, etc.) are hidden rather than disabled.
  • HPLC support: improved formatting and display of retention times and AUC values in comparison mode.
  • Save/submit: write-back uses the active curve index so saved data matches the spectrum the user was working on

@Nicolass67 Nicolass67 marked this pull request as ready for review June 12, 2026 07:39
@Nicolass67 Nicolass67 requested a review from headri June 12, 2026 08:52
@PiTrem PiTrem requested a review from Copilot June 15, 2026 12:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants