Skip to content

[Partner Nodes] chore(Google): remove preview versions of models that will be deprecated soon#14555

Open
bigcat88 wants to merge 1 commit into
masterfrom
chore/api-nodes/remove-google-preview-models
Open

[Partner Nodes] chore(Google): remove preview versions of models that will be deprecated soon#14555
bigcat88 wants to merge 1 commit into
masterfrom
chore/api-nodes/remove-google-preview-models

Conversation

@bigcat88

@bigcat88 bigcat88 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

These models will be completely removed from VertexAI at July 9, 2026

API Node PR Checklist

Scope

  • Is API Node Change

Pricing & Billing

  • Need pricing update
  • No pricing update

If Need pricing update:

  • Metronome rate cards updated
  • Auto‑billing tests updated and passing

QA

  • QA done
  • QA not required

Comms

  • Informed Kosinkadink

… will be deprecated soon

Signed-off-by: bigcat88 <bigcat88@icloud.com>
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The changes in comfy_api_nodes/nodes_gemini.py remove the GeminiImageModel enum and its Enum import. The GeminiNode legacy text node's model selector drops two preview variants (gemini-2.5-pro-preview-05-06 and gemini-2.5-flash-preview-04-17). The GeminiImageNode schema replaces the now-deleted enum-based options with an explicit list containing only "gemini-2.5-flash-image". The calculate_tokens_price function's Gemini 2.5 pricing logic is rewritten from set-membership checks (covering multiple preview/stable strings) to direct == comparisons for each specific model version string.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: removing preview versions of Google models that will be deprecated, which directly corresponds to the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description clearly relates to the changeset: removing preview model variants from Gemini model handling due to VertexAI deprecation on July 9, 2026.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant