Skip to content

fix: filter WS messages by workflow tab to prevent cross-tab state leaking #10689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
christian-byrne wants to merge 11 commits into from
Closed

fix: filter WS messages by workflow tab to prevent cross-tab state leaking #10689

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4f505dc
fix: filter WS messages by workflow tab to prevent cross-tab state le…
christian-byrne Mar 28, 2026
6b11e5a
fix: gate preview revocation behind isJobForActiveWorkflow
christian-byrne Mar 29, 2026
ef6030d
fix: rehydrate nodeProgressStates on workflow tab switch
christian-byrne Mar 29, 2026
4730a53
test: add tab-switch rehydration and preview gating tests
christian-byrne Mar 29, 2026
fb96e64
fix: persist job-to-workflow map in sessionStorage via window.name po…
christian-byrne Mar 30, 2026
de6eb5a
[automated] Apply ESLint and Oxfmt fixes
actions-user Mar 30, 2026
324ef4f
fix: clear/rehydrate _executingNodeProgress on workflow tab switch
christian-byrne Apr 10, 2026
8a26ac6
fix: guard maxEntries against negative values in createSessionTabMap
christian-byrne Apr 10, 2026
f500e0d
fix: delete legacy key only after successful migration parse
christian-byrne Apr 10, 2026
8a5a6d0
Merge branch 'main' into prompt-tab-graph-state-sync-fix
DrJKL Apr 16, 2026
deadcb3
fix: remove unused SessionTabMap export to satisfy knip
christian-byrne Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/scripts/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,6 +722,8 @@ export class ComfyApp {
})

api.addEventListener('executed', ({ detail }) => {
if (!useExecutionStore().isJobForActiveWorkflow(detail.prompt_id)) return

const nodeOutputStore = useNodeOutputStore()
const executionId = String(detail.display_node || detail.node)

Expand Down Expand Up @@ -764,6 +766,8 @@ export class ComfyApp {
})

api.addEventListener('b_preview_with_metadata', ({ detail }) => {
if (!useExecutionStore().isJobForActiveWorkflow(detail.jobId)) return

// Enhanced preview with explicit node context
const { blob, displayNodeId, jobId } = detail
const { setNodePreviewsByExecutionId, revokePreviewsByExecutionId } =
Expand Down
Loading
Loading