fix(load3d): preserve unknown Model Config fields with spread#11838
Open
christian-byrne wants to merge 1 commit intomainfrom
Open
fix(load3d): preserve unknown Model Config fields with spread#11838christian-byrne wants to merge 1 commit intomainfrom
christian-byrne wants to merge 1 commit intomainfrom
Conversation
Read existing nodeValue.properties[Model Config] and spread it before applying known keys in restoreInitialState() and applyChanges(), so any future ModelConfig fields are not silently dropped when the viewer dialog is opened, cancelled, or applied. Also removes the hard-coded showSkeleton: false override from applyChanges() so it falls through from the existing config. Fixes #11346
Contributor
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 0/5 reviews remaining, refill in 9 minutes and 30 seconds. Comment |
dosubot
Bot
added
the
size:XS
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ✅ 1461 passed, 0 failed · 3 flaky📊 Browser Reports
|
📦 Bundle: 5.25 MB gzip 🟢 -36 BDetailsSummary
Category Glance App Entry Points — 22.6 kB (baseline 22.6 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.24 MB (baseline 1.24 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 81.8 kB (baseline 81.8 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 489 kB (baseline 489 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 11 unchanged User & Accounts — 17.5 kB (baseline 17.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 112 kB (baseline 112 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed UI Components — 62.9 kB (baseline 62.9 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 9 unchanged Data & Services — 3.04 MB (baseline 3.04 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 365 kB (baseline 365 kB) • 🔴 +169 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 18 unchanged Vendor & Third-Party — 9.94 MB (baseline 9.94 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.84 MB (baseline 8.84 MB) • ⚪ 0 BBundles that do not match a named category
Status: 57 added / 57 removed / 78 unchanged ⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-05-02T07:05:55.878Z",
"gitSha": "1a653d74c817b37f6ae83d54f057c635f2d44251",
"branch": "batch-dispatch/cr-11346",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1996.383000000037,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.5450000000000035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.75399999999996,
"heapDeltaBytes": 22690192,
"heapUsedBytes": 71094428,
"domNodes": 16,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 20.049999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2014.3410000000017,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.763999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.644,
"heapDeltaBytes": 23089952,
"heapUsedBytes": 70805412,
"domNodes": 20,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 25.328000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2010.2090000000317,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.4190000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.113,
"heapDeltaBytes": 22788240,
"heapUsedBytes": 71416596,
"domNodes": 16,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 22.753999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2014.5390000000134,
"styleRecalcs": 79,
"styleRecalcDurationMs": 50.02000000000001,
"layouts": 12,
"layoutDurationMs": 4.484,
"taskDurationMs": 946.224,
"heapDeltaBytes": 18086512,
"heapUsedBytes": 67392304,
"domNodes": 57,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 139.441,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2023.4990000000153,
"styleRecalcs": 81,
"styleRecalcDurationMs": 44.682,
"layouts": 12,
"layoutDurationMs": 3.563,
"taskDurationMs": 1040.047,
"heapDeltaBytes": 6148836,
"heapUsedBytes": 54231152,
"domNodes": -262,
"jsHeapTotalBytes": 15331328,
"scriptDurationMs": 122.887,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1801.7399999999952,
"styleRecalcs": 71,
"styleRecalcDurationMs": 34.629999999999995,
"layouts": 12,
"layoutDurationMs": 3.3960000000000004,
"taskDurationMs": 846.3130000000001,
"heapDeltaBytes": 3234272,
"heapUsedBytes": 51872064,
"domNodes": -269,
"jsHeapTotalBytes": 14544896,
"scriptDurationMs": 124.167,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1718.0339999999887,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.201,
"layouts": 6,
"layoutDurationMs": 0.609,
"taskDurationMs": 309.407,
"heapDeltaBytes": 174848,
"heapUsedBytes": 48832344,
"domNodes": 76,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 20.923,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1747.7860000000192,
"styleRecalcs": 33,
"styleRecalcDurationMs": 18.331999999999997,
"layouts": 6,
"layoutDurationMs": 0.7390000000000001,
"taskDurationMs": 399.892,
"heapDeltaBytes": 15727248,
"heapUsedBytes": 64615008,
"domNodes": -184,
"jsHeapTotalBytes": 9134080,
"scriptDurationMs": 32.652,
"eventListeners": -108,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.595000000012,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.847,
"layouts": 6,
"layoutDurationMs": 0.6449999999999999,
"taskDurationMs": 342.48,
"heapDeltaBytes": 174684,
"heapUsedBytes": 48543048,
"domNodes": 75,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 24.218999999999998,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 545.8280000000286,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.946999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.39099999999996,
"heapDeltaBytes": 8769492,
"heapUsedBytes": 57332444,
"domNodes": 18,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 55.428000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 554.4140000000084,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.395,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 342.58900000000006,
"heapDeltaBytes": -12286684,
"heapUsedBytes": 53940708,
"domNodes": 18,
"jsHeapTotalBytes": 19755008,
"scriptDurationMs": 55.778999999999996,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 562.8330000000688,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.668999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.31999999999994,
"heapDeltaBytes": 9125516,
"heapUsedBytes": 57217748,
"domNodes": 16,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 56.149,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2024.7490000000425,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.678,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 633.967,
"heapDeltaBytes": 3518628,
"heapUsedBytes": 61706456,
"domNodes": -265,
"jsHeapTotalBytes": 815104,
"scriptDurationMs": 105.847,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2029.1290000000117,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.588000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.911,
"heapDeltaBytes": 17340452,
"heapUsedBytes": 76630844,
"domNodes": -263,
"jsHeapTotalBytes": 5066752,
"scriptDurationMs": 103.63600000000001,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2053.598999999963,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.500000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 632.1099999999999,
"heapDeltaBytes": 4703600,
"heapUsedBytes": 64483056,
"domNodes": -261,
"jsHeapTotalBytes": 4280320,
"scriptDurationMs": 103.12900000000002,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2159.046999999987,
"styleRecalcs": 68,
"styleRecalcDurationMs": 17.730999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1184.3539999999998,
"heapDeltaBytes": 8408248,
"heapUsedBytes": 67858028,
"domNodes": -261,
"jsHeapTotalBytes": -290816,
"scriptDurationMs": 432.083,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2107.0570000000544,
"styleRecalcs": 69,
"styleRecalcDurationMs": 18.240999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1134.59,
"heapDeltaBytes": 5040912,
"heapUsedBytes": 64040564,
"domNodes": -259,
"jsHeapTotalBytes": 1019904,
"scriptDurationMs": 385.349,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2136.4379999999983,
"styleRecalcs": 68,
"styleRecalcDurationMs": 17.921999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1171.9979999999998,
"heapDeltaBytes": 5743420,
"heapUsedBytes": 65112008,
"domNodes": -267,
"jsHeapTotalBytes": 2068480,
"scriptDurationMs": 399.71000000000004,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3198.94400000004,
"styleRecalcs": 65,
"styleRecalcDurationMs": 19.294,
"layouts": 60,
"layoutDurationMs": 7.699000000000001,
"taskDurationMs": 1375.1709999999998,
"heapDeltaBytes": -4578980,
"heapUsedBytes": 56612608,
"domNodes": -268,
"jsHeapTotalBytes": 815104,
"scriptDurationMs": 501.4080000000001,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3171.0369999999557,
"styleRecalcs": 65,
"styleRecalcDurationMs": 18.7,
"layouts": 60,
"layoutDurationMs": 7.786999999999999,
"taskDurationMs": 1329.2459999999999,
"heapDeltaBytes": 743172,
"heapUsedBytes": 62860116,
"domNodes": -267,
"jsHeapTotalBytes": 4280320,
"scriptDurationMs": 468.87100000000004,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3182.003000000009,
"styleRecalcs": 64,
"styleRecalcDurationMs": 18.585,
"layouts": 60,
"layoutDurationMs": 7.837000000000001,
"taskDurationMs": 1374.1830000000002,
"heapDeltaBytes": -6628784,
"heapUsedBytes": 54523672,
"domNodes": -269,
"jsHeapTotalBytes": 815104,
"scriptDurationMs": 492.69599999999997,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.3850000000093,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.567000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.452,
"heapDeltaBytes": 16836008,
"heapUsedBytes": 77723752,
"domNodes": -263,
"jsHeapTotalBytes": 3493888,
"scriptDurationMs": 105.755,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.7099999999655,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.163,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.5000000000001,
"heapDeltaBytes": 8158164,
"heapUsedBytes": 68739092,
"domNodes": -263,
"jsHeapTotalBytes": 4018176,
"scriptDurationMs": 104.842,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2029.8970000000054,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.660000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.5529999999999,
"heapDeltaBytes": 6472324,
"heapUsedBytes": 66835724,
"domNodes": -264,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 102.71900000000001,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 534.148000000016,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.493000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 342.643,
"heapDeltaBytes": 9084732,
"heapUsedBytes": 59034456,
"domNodes": 17,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 113.47699999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.70099999993,
"styleRecalcs": 44,
"styleRecalcDurationMs": 12.572,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.07599999999996,
"heapDeltaBytes": 9346628,
"heapUsedBytes": 57769080,
"domNodes": 14,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 139.674,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 541.8529999999464,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.137999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.259,
"heapDeltaBytes": 9470308,
"heapUsedBytes": 57796076,
"domNodes": 20,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 118.76499999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2031.6970000000083,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.297,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.89399999999995,
"heapDeltaBytes": 23324060,
"heapUsedBytes": 71493872,
"domNodes": 20,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 19.136,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.3020000000483,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.518,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.629,
"heapDeltaBytes": 22457324,
"heapUsedBytes": 71184936,
"domNodes": 20,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 19.072,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1993.9079999999194,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.269999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.84,
"heapDeltaBytes": 22596872,
"heapUsedBytes": 71238128,
"domNodes": 16,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 19.515,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1783.900000000017,
"styleRecalcs": 74,
"styleRecalcDurationMs": 40.711999999999996,
"layouts": 16,
"layoutDurationMs": 5.063,
"taskDurationMs": 800.647,
"heapDeltaBytes": -1710300,
"heapUsedBytes": 47032496,
"domNodes": -264,
"jsHeapTotalBytes": 14807040,
"scriptDurationMs": 97.274,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.2940000000472,
"styleRecalcs": 75,
"styleRecalcDurationMs": 36.212,
"layouts": 16,
"layoutDurationMs": 4.472,
"taskDurationMs": 734.2529999999999,
"heapDeltaBytes": -1581556,
"heapUsedBytes": 47041828,
"domNodes": -263,
"jsHeapTotalBytes": 15593472,
"scriptDurationMs": 88.177,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1698.034000000007,
"styleRecalcs": 74,
"styleRecalcDurationMs": 38.589999999999996,
"layouts": 16,
"layoutDurationMs": 5.050000000000001,
"taskDurationMs": 730.8240000000001,
"heapDeltaBytes": 14753592,
"heapUsedBytes": 64363064,
"domNodes": 59,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 92.70599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8134.204000000011,
"styleRecalcs": 249,
"styleRecalcDurationMs": 53.442,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3793.894,
"heapDeltaBytes": 17490992,
"heapUsedBytes": 76191508,
"domNodes": -261,
"jsHeapTotalBytes": 2330624,
"scriptDurationMs": 1258.569,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8136.056000000053,
"styleRecalcs": 249,
"styleRecalcDurationMs": 54.32599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3933.712,
"heapDeltaBytes": 20721044,
"heapUsedBytes": 79383176,
"domNodes": -260,
"jsHeapTotalBytes": 3379200,
"scriptDurationMs": 1297.893,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8189.814000000069,
"styleRecalcs": 250,
"styleRecalcDurationMs": 55.88799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4058.6409999999996,
"heapDeltaBytes": 11491636,
"heapUsedBytes": 69522432,
"domNodes": -264,
"jsHeapTotalBytes": 4165632,
"scriptDurationMs": 1313.287,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 11161.283000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11145.180999999999,
"heapDeltaBytes": -51861048,
"heapUsedBytes": 165239344,
"domNodes": -8434,
"jsHeapTotalBytes": 17915904,
"scriptDurationMs": 592.6709999999999,
"eventListeners": -16466,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10767.365000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10753.164999999999,
"heapDeltaBytes": -18396580,
"heapUsedBytes": 191313560,
"domNodes": -8331,
"jsHeapTotalBytes": 24178688,
"scriptDurationMs": 589.064,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10871.858999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10854.657,
"heapDeltaBytes": -25220132,
"heapUsedBytes": 171876112,
"domNodes": -8331,
"jsHeapTotalBytes": 24965120,
"scriptDurationMs": 573.4379999999999,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 12705.896999999994,
"styleRecalcs": 64,
"styleRecalcDurationMs": 17.319999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12672.466999999997,
"heapDeltaBytes": -20502724,
"heapUsedBytes": 179177904,
"domNodes": -8331,
"jsHeapTotalBytes": 24354816,
"scriptDurationMs": 881.7779999999999,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 12546.215999999959,
"styleRecalcs": 64,
"styleRecalcDurationMs": 17.373000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12525.448999999999,
"heapDeltaBytes": -21999192,
"heapUsedBytes": 179357980,
"domNodes": -8331,
"jsHeapTotalBytes": 23830528,
"scriptDurationMs": 846.642,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13059.463999999934,
"styleRecalcs": 66,
"styleRecalcDurationMs": 18.492000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13036.803,
"heapDeltaBytes": -59310168,
"heapUsedBytes": 153700528,
"domNodes": -8331,
"jsHeapTotalBytes": -3870720,
"scriptDurationMs": 873.312,
"eventListeners": -16488,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 473.1519999999705,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.229,
"layouts": 5,
"layoutDurationMs": 1.668,
"taskDurationMs": 141.79399999999998,
"heapDeltaBytes": 5417172,
"heapUsedBytes": 55461416,
"domNodes": 168,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 30.374,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 466.3110000000188,
"styleRecalcs": 15,
"styleRecalcDurationMs": 23.047,
"layouts": 5,
"layoutDurationMs": 1.6030000000000002,
"taskDurationMs": 127.54000000000002,
"heapDeltaBytes": 5053204,
"heapUsedBytes": 56185848,
"domNodes": 155,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 26.23,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 139.4669999999678,
"styleRecalcs": 13,
"styleRecalcDurationMs": 20.27,
"layouts": 4,
"layoutDurationMs": 1.7570000000000001,
"taskDurationMs": 105.175,
"heapDeltaBytes": 3478620,
"heapUsedBytes": 53379408,
"domNodes": 148,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 24.117000000000004,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #11838 +/- ##
===========================================
- Coverage 71.66% 55.42% -16.24%
===========================================
Files 1491 1382 -109
Lines 86124 70574 -15550
Branches 23274 19662 -3612
===========================================
- Hits 61718 39119 -22599
- Misses 23536 30928 +7392
+ Partials 870 527 -343
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 992 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use spread pattern when writing
nodeValue.properties['Model Config']so future ModelConfig fields are preserved across viewer dialog cancel/apply.Changes
Model Configbefore applying known keys in bothrestoreInitialState()andapplyChanges()in useLoad3dViewer.ts. Removes the hard-codedshowSkeleton: falseoverride fromapplyChanges()so it falls through from the existing config.Review Focus
The change is intentionally minimal and matches the suggestion in the upstream issue. Two regression tests added (one each for restore/apply) verify that an unknown future field on Model Config survives both code paths.
Fixes #11346
┆Issue is synchronized with this Notion page by Unito