Skip to content

fix(website): point Install via GitHub buttons to install docs anchor #11852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-byrne merged 2 commits into from
May 4, 2026
Merged

fix(website): point Install via GitHub buttons to install docs anchor #11852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0ccb69
fix(website): point Install via GitHub buttons to install docs anchor
Glary-Bot May 2, 2026
7830006
test(website): update HeroSection GitHub button URL assertion to #ins…
Glary-Bot May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/website/e2e/download.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ test.describe('Download page @smoke', () => {
await expect(githubBtn).toBeVisible()
await expect(githubBtn).toHaveAttribute(
'href',
'https://github.com/Comfy-Org/ComfyUI'
'https://github.com/Comfy-Org/ComfyUI#installing'
)

await context.close()
Expand Down
6 changes: 5 additions & 1 deletion apps/website/src/components/product/local/EcoSystemSection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,11 @@ const { locale = 'en' } = defineProps<{ locale?: Locale }>()
<!-- CTA buttons -->
<div class="mt-10 flex flex-col gap-4 lg:flex-row">
<DownloadLocalButton :locale />
<BrandButton :href="externalLinks.github" variant="outline" size="lg">
<BrandButton
:href="externalLinks.githubInstall"
variant="outline"
size="lg"
>
<span class="inline-flex items-center gap-2">
<i
class="icon-mask size-5 -translate-y-px mask-[url('/icons/social/github.svg')]"
Expand Down
2 changes: 1 addition & 1 deletion apps/website/src/components/product/local/HeroSection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ onUnmounted(() => {
<div class="mt-8 flex flex-col gap-4 lg:flex-row">
<DownloadLocalButton :locale class="lg:min-w-60 lg:p-4" />
<BrandButton
:href="externalLinks.github"
:href="externalLinks.githubInstall"
variant="outline"
size="lg"
class="lg:min-w-60 lg:p-4"
Expand Down
1 change: 1 addition & 0 deletions apps/website/src/config/routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ export const externalLinks = {
docs: 'https://docs.comfy.org/',
docsApi: 'https://docs.comfy.org/api-reference/cloud',
github: 'https://github.com/Comfy-Org/ComfyUI',
githubInstall: 'https://github.com/Comfy-Org/ComfyUI#installing',
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

Does the ComfyUI README at https://github.com/Comfy-Org/ComfyUI currently have a heading that generates the anchor #installing?

💡 Result:

No. The current ComfyUI README at https://github.com/Comfy-Org/ComfyUI/blob/master/README.md does not have a heading whose generated anchor would be #installing. In the README’s installation section headings, the visible subheading is “Manual Install (Windows, Linux)” (and then “Instructions:” / platform-specific subheadings), rather than a heading named “Installing”, which would be required for an anchor like #installing.

Citations:

Fix the GitHub URL: the #installing anchor does not exist in the ComfyUI README

The ComfyUI README does not have a heading that generates the #installing anchor. The installation section uses headings like "Manual Install (Windows, Linux)" instead. This link will direct users to the top of the README rather than the installation section, defeating its purpose.

Either update the URL to point to an existing section (e.g., by checking the actual README structure), or coordinate with the ComfyUI team to add an "Installing" heading to their README before merging this change.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@apps/website/src/config/routes.ts` at line 37, The githubInstall route value
(githubInstall) points to a non-existent README anchor "#installing"; update the
URL to a valid anchor or to the README root: inspect the ComfyUI README to find
the correct section anchor (e.g., the actual heading slug such as
"#manual-install-windows-linux" if present) and replace
'https://github.com/Comfy-Org/ComfyUI#installing' with the verified URL, or
remove the fragment to link to the top-level README until the upstream adds an
"Installing" heading.

Copy link
Copy Markdown

@glary-bot glary-bot Bot May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushing back on this — the #installing anchor does exist in the upstream ComfyUI README.

Fetching the raw README right now (https://raw.githubusercontent.com/comfyanonymous/ComfyUI/master/README.md), there's a top-level heading:

# Installing

…which GitHub renders with id="installing" per its slug algorithm (lowercase, spaces→hyphens). The README itself relies on this anchor — its own "Get Started" section links there:

#### [Windows Portable Package](#installing)

So the link https://github.com/Comfy-Org/ComfyUI#installing jumps to the Installing section as intended. (Comfy-Org/ComfyUI redirects to comfyanonymous/ComfyUI, which serves this README.)

CodeRabbit's web search appears to have missed the # Installing H1 between the Shortcuts table and the Windows Portable subsection. No change needed.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped: comment is from another GitHub bot.

platform: 'https://platform.comfy.org',
workflows: 'https://comfy.org/workflows',
youtube: 'https://www.youtube.com/@ComfyOrg'
Expand Down
Loading