-
Notifications
You must be signed in to change notification settings - Fork 561
feat(validation): split topology validation from link repair into publishable nx package #11864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
christian-byrne
wants to merge
8
commits into
main
Choose a base branch
from
glary/workflow-validation-package
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
72ac677
feat(validation): split topology validation from link repair into pub…
Glary-Bot 5ee6e62
fix(validation): make workflow-validation package buildable for npm p…
Glary-Bot 0eeddb6
chore: drop publish workflow YAML pending workflows-permission grant
Glary-Bot 1f795c7
fix(validation): address CodeRabbit review feedback
Glary-Bot ea2e0fe
fix(validation): clone graph before repair and i18n the topology deta…
Glary-Bot 958b7eb
fix(validation): use tsconfig project reference instead of allowDefau…
Glary-Bot 145fd39
test(validation): add unit coverage for useWorkflowValidation and lin…
Glary-Bot 0764076
fix(storybook): add aliases for workflow-validation package paths
christian-byrne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,7 @@ yarn.lock | |
| .eslintcache | ||
| .prettiercache | ||
| .stylelintcache | ||
| *.tsbuildinfo | ||
|
|
||
| node_modules | ||
| .pnpm-store | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| { | ||
| "name": "@comfyorg/workflow-validation", | ||
| "version": "0.1.0", | ||
| "description": "Workflow JSON schemas, link topology validator, and link repair for ComfyUI workflows", | ||
| "homepage": "https://comfy.org", | ||
| "license": "GPL-3.0-only", | ||
| "repository": "https://github.com/Comfy-Org/ComfyUI_frontend", | ||
| "type": "module", | ||
| "main": "./src/index.ts", | ||
| "types": "./src/index.ts", | ||
| "exports": { | ||
| ".": "./src/index.ts", | ||
| "./linkRepair": "./src/linkRepair.ts", | ||
| "./linkTopology": "./src/linkTopology.ts", | ||
| "./workflowSchema": "./src/workflowSchema.ts", | ||
| "./serialised": "./src/serialised.ts" | ||
| }, | ||
| "publishConfig": { | ||
| "access": "public" | ||
| }, | ||
| "scripts": { | ||
| "build": "vite build --config vite.config.mts && tsx ../../scripts/prepare-workflow-validation.ts", | ||
| "typecheck": "tsc --noEmit" | ||
| }, | ||
| "dependencies": { | ||
| "zod": "catalog:", | ||
| "zod-validation-error": "catalog:" | ||
| }, | ||
| "devDependencies": { | ||
| "typescript": "catalog:", | ||
| "vite": "catalog:", | ||
| "vite-plugin-dts": "catalog:" | ||
| }, | ||
| "packageManager": "pnpm@10.17.1", | ||
| "nx": { | ||
| "tags": [ | ||
| "scope:shared", | ||
| "type:validation" | ||
| ] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| export type { | ||
| SerialisedGraph, | ||
| SerialisedLinkArray, | ||
| SerialisedLinkObject, | ||
| SerialisedNode, | ||
| SerialisedNodeInput, | ||
| SerialisedNodeOutput | ||
| } from './serialised' | ||
|
|
||
| export { | ||
| describeTopologyError, | ||
| toLinkContext, | ||
| validateLinkTopology | ||
| } from './linkTopology' | ||
| export type { LinkContext, TopologyError } from './linkTopology' | ||
|
|
||
| export { LinkRepairAbortedError, repairLinks } from './linkRepair' | ||
| export type { RepairResult } from './linkRepair' | ||
|
|
||
| export { repairLinks as fixBadLinks } from './linkRepair' | ||
|
|
||
| export { | ||
| validateComfyWorkflow, | ||
| zComfyWorkflow, | ||
| zComfyWorkflow1, | ||
| zNodeId | ||
| } from './workflowSchema' | ||
| export type { | ||
| ComfyApiWorkflow, | ||
| ComfyLinkObject, | ||
| ComfyNode, | ||
| ComfyWorkflowJSON, | ||
| ModelFile, | ||
| NodeId, | ||
| Reroute, | ||
| WorkflowId, | ||
| WorkflowJSON04 | ||
| } from './workflowSchema' |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.