feat: align cloud batch count limit with server-side queue cap#11876
Open
christian-byrne wants to merge 1 commit intomainfrom
Open
feat: align cloud batch count limit with server-side queue cap#11876christian-byrne wants to merge 1 commit intomainfrom
christian-byrne wants to merge 1 commit intomainfrom
Conversation
Raises Comfy.QueueButton.BatchCountLimit on cloud from 32 to 100 to match the server-side MaxQueuedJobsPerUser cap (cloud/infrastructure/dynamicconfig/prod/config.json). Desktop default unchanged at 100.
Contributor
📝 WalkthroughWalkthroughThe PR removes environment-dependent logic from the ChangesBatch Limit Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ✅ 1467 passed, 0 failed📊 Browser Reports
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
Thanks for the review @coderabbitai — approval noted, no actionable feedback to address. |
📦 Bundle: 5.26 MB gzip 🟢 -32 BDetailsSummary
Category Glance App Entry Points — 22.6 kB (baseline 22.6 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.24 MB (baseline 1.24 MB) • 🟢 -15 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 81.8 kB (baseline 81.8 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 489 kB (baseline 489 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 11 unchanged User & Accounts — 17.5 kB (baseline 17.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 112 kB (baseline 112 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed UI Components — 62.9 kB (baseline 62.9 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 9 unchanged Data & Services — 3.04 MB (baseline 3.04 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 365 kB (baseline 365 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 18 unchanged Vendor & Third-Party — 9.94 MB (baseline 9.94 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.84 MB (baseline 8.84 MB) • ⚪ 0 BBundles that do not match a named category
Status: 57 added / 57 removed / 78 unchanged ⚡ Performance Report
No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-05-04T03:18:54.207Z",
"gitSha": "c4c01f8871373892473ac4205499bca433da3860",
"branch": "glary/raise-cloud-batch-count-limit-100",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2034.3659999999772,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.415000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.602,
"heapDeltaBytes": 23691904,
"heapUsedBytes": 73068444,
"domNodes": 16,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 17.897000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2021.639999999934,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.395,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.906,
"heapDeltaBytes": 23382412,
"heapUsedBytes": 71453400,
"domNodes": 20,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 22.235999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2034.7779999999602,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.193000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.132,
"heapDeltaBytes": 23029588,
"heapUsedBytes": 71320200,
"domNodes": 18,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 19.997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2010.3349999999978,
"styleRecalcs": 79,
"styleRecalcDurationMs": 48.311,
"layouts": 12,
"layoutDurationMs": 4.199,
"taskDurationMs": 934.461,
"heapDeltaBytes": 1515688,
"heapUsedBytes": 49215464,
"domNodes": -261,
"jsHeapTotalBytes": 15331328,
"scriptDurationMs": 141.149,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1789.623000000006,
"styleRecalcs": 72,
"styleRecalcDurationMs": 36.664,
"layouts": 12,
"layoutDurationMs": 3.438,
"taskDurationMs": 798.15,
"heapDeltaBytes": -2125952,
"heapUsedBytes": 46215780,
"domNodes": -265,
"jsHeapTotalBytes": 15331328,
"scriptDurationMs": 120.90500000000002,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1868.714999999952,
"styleRecalcs": 73,
"styleRecalcDurationMs": 37.729,
"layouts": 12,
"layoutDurationMs": 3.9140000000000006,
"taskDurationMs": 812.032,
"heapDeltaBytes": 3597436,
"heapUsedBytes": 51871212,
"domNodes": -264,
"jsHeapTotalBytes": 14544896,
"scriptDurationMs": 122.34500000000001,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1747.2060000000056,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.987999999999996,
"layouts": 6,
"layoutDurationMs": 0.7309999999999999,
"taskDurationMs": 300.23299999999995,
"heapDeltaBytes": 217276,
"heapUsedBytes": 48868916,
"domNodes": 75,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 24.883000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.1959999999071,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.495999999999995,
"layouts": 6,
"layoutDurationMs": 0.5820000000000001,
"taskDurationMs": 305.574,
"heapDeltaBytes": 102028,
"heapUsedBytes": 48466036,
"domNodes": 76,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 20.564,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.2040000000334,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.919000000000004,
"layouts": 6,
"layoutDurationMs": 0.5939999999999999,
"taskDurationMs": 284.30899999999997,
"heapDeltaBytes": 168876,
"heapUsedBytes": 48816500,
"domNodes": 76,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 21.134,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 594.0519999999765,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.533000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.1259999999999,
"heapDeltaBytes": 9147116,
"heapUsedBytes": 57874692,
"domNodes": 16,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 58.96699999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 536.2760000000435,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.8229999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 316.531,
"heapDeltaBytes": 9154208,
"heapUsedBytes": 58450488,
"domNodes": 16,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 53.205,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 584.3340000000126,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.978999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 324.023,
"heapDeltaBytes": 9119496,
"heapUsedBytes": 57458464,
"domNodes": 17,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 61.321,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2011.618999999996,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.547999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 603.007,
"heapDeltaBytes": 14425140,
"heapUsedBytes": 72829776,
"domNodes": -264,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 95.853,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.360999999909,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.634000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.7700000000001,
"heapDeltaBytes": 4255300,
"heapUsedBytes": 62223636,
"domNodes": -265,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 86.132,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2013.1569999999783,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.142,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.6659999999999,
"heapDeltaBytes": 5069400,
"heapUsedBytes": 63530528,
"domNodes": -262,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 79.399,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2132.8940000000216,
"styleRecalcs": 67,
"styleRecalcDurationMs": 17.296000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1045.8890000000001,
"heapDeltaBytes": 6191440,
"heapUsedBytes": 65483252,
"domNodes": -266,
"jsHeapTotalBytes": 233472,
"scriptDurationMs": 365.096,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2145.07500000002,
"styleRecalcs": 67,
"styleRecalcDurationMs": 17.538999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1062.049,
"heapDeltaBytes": 3248280,
"heapUsedBytes": 62631256,
"domNodes": -266,
"jsHeapTotalBytes": 757760,
"scriptDurationMs": 372.81399999999996,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2112.3209999999517,
"styleRecalcs": 68,
"styleRecalcDurationMs": 17.557999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1035.574,
"heapDeltaBytes": -1417500,
"heapUsedBytes": 58155952,
"domNodes": -266,
"jsHeapTotalBytes": 6262784,
"scriptDurationMs": 359.908,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3163.8289999999643,
"styleRecalcs": 64,
"styleRecalcDurationMs": 18.469999999999995,
"layouts": 60,
"layoutDurationMs": 7.924,
"taskDurationMs": 1382.106,
"heapDeltaBytes": -2512668,
"heapUsedBytes": 58605720,
"domNodes": -270,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 538.218,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3084.8479999999654,
"styleRecalcs": 64,
"styleRecalcDurationMs": 17.477999999999998,
"layouts": 60,
"layoutDurationMs": 8.041,
"taskDurationMs": 1288.3029999999999,
"heapDeltaBytes": -7798520,
"heapUsedBytes": 53368476,
"domNodes": -268,
"jsHeapTotalBytes": 815104,
"scriptDurationMs": 472.56899999999996,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3118.64700000001,
"styleRecalcs": 64,
"styleRecalcDurationMs": 17.949999999999996,
"layouts": 60,
"layoutDurationMs": 7.9719999999999995,
"taskDurationMs": 1295.5330000000001,
"heapDeltaBytes": 10679792,
"heapUsedBytes": 72245900,
"domNodes": -267,
"jsHeapTotalBytes": 5328896,
"scriptDurationMs": 470.09399999999994,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2022.4059999999895,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.150999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.066,
"heapDeltaBytes": 11486448,
"heapUsedBytes": 71650976,
"domNodes": -265,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 88.671,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2033.7070000000494,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.666000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 610.239,
"heapDeltaBytes": 6833888,
"heapUsedBytes": 67002120,
"domNodes": -265,
"jsHeapTotalBytes": 815104,
"scriptDurationMs": 98.786,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2029.05300000009,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.5210000000000035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.576,
"heapDeltaBytes": 3357456,
"heapUsedBytes": 63586280,
"domNodes": -265,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 79.36500000000002,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 535.9770000000026,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.982000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 344.53099999999995,
"heapDeltaBytes": 9166780,
"heapUsedBytes": 57790976,
"domNodes": 18,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 118.739,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 566.0769999999502,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.233,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.60800000000006,
"heapDeltaBytes": -11263556,
"heapUsedBytes": 57259852,
"domNodes": 20,
"jsHeapTotalBytes": 18444288,
"scriptDurationMs": 123.837,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.4480000000749,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.249,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.30600000000004,
"heapDeltaBytes": 9365564,
"heapUsedBytes": 58026060,
"domNodes": 16,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 120.751,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2002.8409999999894,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.843,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.368,
"heapDeltaBytes": 22513464,
"heapUsedBytes": 70917912,
"domNodes": 18,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 14.526000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1996.599999999944,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.747,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.18499999999995,
"heapDeltaBytes": 23333176,
"heapUsedBytes": 71890808,
"domNodes": 16,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 14.571000000000007,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2006.4250000000357,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.264000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.17999999999995,
"heapDeltaBytes": 22369476,
"heapUsedBytes": 70945776,
"domNodes": 18,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 13.724999999999994,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1672.411000000011,
"styleRecalcs": 75,
"styleRecalcDurationMs": 36.427,
"layouts": 16,
"layoutDurationMs": 4.471,
"taskDurationMs": 649.517,
"heapDeltaBytes": 14774724,
"heapUsedBytes": 63443916,
"domNodes": 60,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 90.887,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1975.0719999999546,
"styleRecalcs": 83,
"styleRecalcDurationMs": 43.368,
"layouts": 16,
"layoutDurationMs": 4.369000000000001,
"taskDurationMs": 927.476,
"heapDeltaBytes": 1232676,
"heapUsedBytes": 49930840,
"domNodes": -262,
"jsHeapTotalBytes": 14807040,
"scriptDurationMs": 93.793,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.991999999982,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.099,
"layouts": 16,
"layoutDurationMs": 4.3309999999999995,
"taskDurationMs": 700.539,
"heapDeltaBytes": -5214120,
"heapUsedBytes": 43380976,
"domNodes": 62,
"jsHeapTotalBytes": 14807040,
"scriptDurationMs": 92.43799999999999,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8199.644999999975,
"styleRecalcs": 250,
"styleRecalcDurationMs": 57.593,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4059.7320000000004,
"heapDeltaBytes": 19141876,
"heapUsedBytes": 77648828,
"domNodes": -261,
"jsHeapTotalBytes": 10719232,
"scriptDurationMs": 1462.447,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8116.581999999994,
"styleRecalcs": 250,
"styleRecalcDurationMs": 56.653999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3568.825,
"heapDeltaBytes": 13413584,
"heapUsedBytes": 71587960,
"domNodes": -259,
"jsHeapTotalBytes": 2592768,
"scriptDurationMs": 1158.5320000000002,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8155.997999999954,
"styleRecalcs": 249,
"styleRecalcDurationMs": 54.580999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3480.1769999999997,
"heapDeltaBytes": 15240948,
"heapUsedBytes": 73516660,
"domNodes": -262,
"jsHeapTotalBytes": 2330624,
"scriptDurationMs": 1154.4379999999999,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12839.223000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12826.535,
"heapDeltaBytes": -32785692,
"heapUsedBytes": 158005468,
"domNodes": -8329,
"jsHeapTotalBytes": 23130112,
"scriptDurationMs": 582.853,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12934.837000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12915.755000000001,
"heapDeltaBytes": -34709252,
"heapUsedBytes": 178783396,
"domNodes": -8335,
"jsHeapTotalBytes": 24702976,
"scriptDurationMs": 589.375,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12449.817000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12423.055000000002,
"heapDeltaBytes": -31871976,
"heapUsedBytes": 171205460,
"domNodes": -8331,
"jsHeapTotalBytes": 23130112,
"scriptDurationMs": 619.255,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15233.602000000019,
"styleRecalcs": 73,
"styleRecalcDurationMs": 18.118999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15198.806,
"heapDeltaBytes": -18660044,
"heapUsedBytes": 180787736,
"domNodes": -8331,
"jsHeapTotalBytes": -1597440,
"scriptDurationMs": 892.0480000000001,
"eventListeners": -16488,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 15544.03000000002,
"styleRecalcs": 76,
"styleRecalcDurationMs": 19.25300000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15520.883000000002,
"heapDeltaBytes": -47691184,
"heapUsedBytes": 153185780,
"domNodes": -8329,
"jsHeapTotalBytes": 1634304,
"scriptDurationMs": 873.2189999999999,
"eventListeners": -16490,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14736.053999999967,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.375999999999948,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14705.933,
"heapDeltaBytes": -40533744,
"heapUsedBytes": 163288540,
"domNodes": -8331,
"jsHeapTotalBytes": -724992,
"scriptDurationMs": 871.899,
"eventListeners": -16488,
"totalBlockingTimeMs": 55,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 459.6009999999069,
"styleRecalcs": 17,
"styleRecalcDurationMs": 26.41,
"layouts": 6,
"layoutDurationMs": 1.787,
"taskDurationMs": 125.70700000000001,
"heapDeltaBytes": 5306524,
"heapUsedBytes": 55641744,
"domNodes": 164,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 25.12799999999999,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 124.21499999993557,
"styleRecalcs": 11,
"styleRecalcDurationMs": 19.143,
"layouts": 5,
"layoutDurationMs": 1.571,
"taskDurationMs": 95.54299999999999,
"heapDeltaBytes": 3375136,
"heapUsedBytes": 53708812,
"domNodes": 144,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 19.528,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 474.49700000004214,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.333,
"layouts": 5,
"layoutDurationMs": 1.311,
"taskDurationMs": 142.381,
"heapDeltaBytes": -15059768,
"heapUsedBytes": 51779204,
"domNodes": 157,
"jsHeapTotalBytes": 5861376,
"scriptDurationMs": 27.480999999999998,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #11876 +/- ##
===========================================
- Coverage 71.79% 55.96% -15.83%
===========================================
Files 1492 1383 -109
Lines 85011 70621 -14390
Branches 23233 18757 -4476
===========================================
- Hits 61031 39523 -21508
- Misses 23091 30571 +7480
+ Partials 889 527 -362
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 991 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dosubot
Bot
added
the
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Created by the Glary-Bot Agent
Raises
Comfy.QueueButton.BatchCountLimiton cloud from32to100to match the server-sideMaxQueuedJobsPerUsercap (cloud/infrastructure/dynamicconfig/prod/config.json:3). The desktop default was already100and is unchanged — collapsing both branches to the same constant.Addresses Discord feature request: Increase queue batch limit from 200.
Change
The setting is read dynamically by all batch count UIs (
BatchCountEdit.vue,LinearControls.vue).Why 100 (not 512)
Original ask was 200→512. Investigation showed:
100(desktop) /32(cloud), not 200.MaxQueuedJobsPerUser = 100per workspace server-side. A higher frontend cap can't unlock more queued work — extra prompts just get rejected withQUEUE_LIMIT.POST /promptcalls (no batched-prompt endpoint), so the UI cap is purely about how many clicks it takes — not throughput.Known limitation (pre-existing, not introduced here)
The new max equals the absolute server cap, not the user's remaining capacity. A user with already-queued work can hit
QUEUE_LIMITmid-batch. The pre-existing 32 limit had the same shape (just at a smaller scale); deriving the UI max fromcap - outstandingwould require polling and reactive state and is out of scope for a one-line setting bump.Verification
pnpm typecheck— passespnpm lint— 0 errors (1 pre-existing warning in unrelated test file)pnpm test:unit—BatchCountEdit.test.ts(3 tests) +src/platform/settings/**(70 tests) all passsettingStore.get('Comfy.QueueButton.BatchCountLimit')returns100at runtime999into the batch count widget clamps to100100(max reached)Screenshots
┆Issue is synchronized with this Notion page by Unito