[backport core/1.43] fix: use hash lookup for missing asset detection (#11873)#11890
Open
[backport core/1.43] fix: use hash lookup for missing asset detection (#11873)#11890
Conversation
Use exact BLAKE3 hash lookups first for missing model/media detection,
and add a separate public-inclusive input asset cache so public input
assets are considered missing-detection candidates without changing the
user-only input assets shown in the UI.
- **What**:
- Added `assetService.checkAssetHash()` for `HEAD
/api/assets/hash/{hash}` status-only existence checks.
- Added strict BLAKE3 hash helpers so only `blake3:<64 hex>` media
values and raw 64-hex BLAKE3 model metadata are sent to the hash
endpoint.
- Updated missing media detection to group BLAKE3 candidates by hash,
resolve them through the hash endpoint, and fall back to the legacy
asset list path for invalid/unverifiable/non-hash values.
- Updated missing model detection to use hash lookup for BLAKE3-backed
asset-supported candidates before falling back to the existing node-type
asset matching path.
- Added `assetService.getInputAssetsIncludingPublic()` backed by a
dedicated cache that fetches input assets with `include_public=true` for
missing media fallback checks.
- Kept `assetsStore.inputAssets` user-only for widget/UI display, while
invalidating the public-inclusive missing-detection cache when input
assets may change.
- Added abort handling for paginated asset fetches and shared
public-input cache callers so one aborted caller does not cancel the
shared fetch for other callers.
- Added regression coverage for hash lookup, fallback behavior, abort
paths, public input fallback detection, and cache invalidation.
- **Dependencies**: None.
- **Change size**:
- Production code: 4 files, 400 insertions, 24 deletions, net +376.
- Test code: 4 files, 806 insertions, 59 deletions, net +747.
- Total: 8 files, 1206 insertions, 83 deletions, net +1123.
- The public-inclusive input asset cache is intentionally separate from
`assetsStore.inputAssets`. The existing store data is user-only and
drives the asset widgets/sidebar, so using it for missing input
detection misses public assets. Making that store public-inclusive would
change UI data semantics; this PR instead keeps the UI dataset unchanged
and adds a missing-detection-specific cache in `assetService`.
- Hash lookup is only used when the workflow exposes a valid BLAKE3
hash. Filename-like values and invalid hash values still use the legacy
fallback path.
- Missing model detection keeps the existing fallback behavior for
non-hash candidates and for hash checks that are invalid or fail
transiently.
- Async model download cache refresh behavior is left unchanged; this PR
avoids coupling model download completion to input asset cache
invalidation.
- No browser/e2e test was added because this changes the missing asset
detection data path, not UI interaction or rendering. The behavioral
coverage is in unit tests for the asset service and the missing
media/model scanners.
- Fix `assetsStore.updateAssetTags()` partial-failure recovery. If
`removeAssetTags()` succeeds and `addAssetTags()` fails, the local model
asset cache can roll back to tags that the backend has already removed;
this should be handled in a focused model asset cache PR.
- Consider extracting shared hash-verification flow used by missing
media and missing model scans after this behavior stabilizes.
- Consider adding a concurrency cap or short-lived request cache for
large workflows with many unique hash lookups.
- Consider splitting `assetService.ts` further, e.g. hash helpers, abort
utilities, and the public-inclusive input asset cache.
- Consider tightening the asset hash service API shape so callers do not
directly depend on HTTP-oriented statuses such as `invalid`.
- Consider adding broader mutation-path coverage for public-inclusive
input cache invalidation once the cache has more consumers.
Linear: FE-534
Before <false positive / missing image / public asset>
https://github.com/user-attachments/assets/db7ce2a9-b169-4fae-bf9f-98bb93d3ee6d
After
https://github.com/user-attachments/assets/29af9f9e-b536-4fcd-a426-3add40bcb165
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-11873-Use-hash-lookup-for-missing-asset-detection-3556d73d36508165babafb16614be0d8)
by [Unito](https://www.unito.io)
(cherry picked from commit 0491836)
dosubot
Bot
added
the
size:L
Contributor
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ✅ 1046 passed, 0 failed · 2 flaky📊 Browser Reports
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.43 #11890 +/- ##
=============================================
+ Coverage 44.27% 44.61% +0.33%
=============================================
Files 1344 1344
Lines 68867 69041 +174
Branches 18211 18267 +56
=============================================
+ Hits 30494 30803 +309
+ Misses 37778 37643 -135
Partials 595 595
🚀 New features to boost your workflow:
|
📦 Bundle Size
⚡ Performance Report
No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-05-04T07:01:41.277Z",
"gitSha": "c0f8e6d4caf33d538aa8416c71775692c87b6c8e",
"branch": "codex/backport-11873-core-1.43",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2011.2799999999993,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.977999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.646,
"heapDeltaBytes": 20561952,
"heapUsedBytes": 63592656,
"domNodes": 16,
"jsHeapTotalBytes": 22282240,
"scriptDurationMs": 20.449,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2015.355999999997,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.326,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 343.906,
"heapDeltaBytes": 20682536,
"heapUsedBytes": 64969628,
"domNodes": 20,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 20.304,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2026.7010000000028,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.630999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.12,
"heapDeltaBytes": 21096596,
"heapUsedBytes": 63916160,
"domNodes": 22,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 23.48,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2068.80000000001,
"styleRecalcs": 84,
"styleRecalcDurationMs": 44.441,
"layouts": 12,
"layoutDurationMs": 3.309,
"taskDurationMs": 991.978,
"heapDeltaBytes": 16269752,
"heapUsedBytes": 59231104,
"domNodes": 68,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 140.78000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1724.726999999973,
"styleRecalcs": 74,
"styleRecalcDurationMs": 32.966,
"layouts": 12,
"layoutDurationMs": 3.5170000000000003,
"taskDurationMs": 709.151,
"heapDeltaBytes": 16093572,
"heapUsedBytes": 58959136,
"domNodes": 58,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 129.904,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1798.989000000006,
"styleRecalcs": 74,
"styleRecalcDurationMs": 35.41,
"layouts": 12,
"layoutDurationMs": 3.5820000000000003,
"taskDurationMs": 725.4350000000001,
"heapDeltaBytes": 16529456,
"heapUsedBytes": 59522492,
"domNodes": 57,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 128.81500000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.209000000003,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.148999999999997,
"layouts": 6,
"layoutDurationMs": 0.6200000000000001,
"taskDurationMs": 301.925,
"heapDeltaBytes": 358032,
"heapUsedBytes": 49247288,
"domNodes": 80,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 24.5,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1742.5479999999993,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.354,
"layouts": 6,
"layoutDurationMs": 0.521,
"taskDurationMs": 287.69800000000004,
"heapDeltaBytes": 25066936,
"heapUsedBytes": 67935652,
"domNodes": 79,
"jsHeapTotalBytes": 20971520,
"scriptDurationMs": 23.12600000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1732.8660000000582,
"styleRecalcs": 33,
"styleRecalcDurationMs": 18.26,
"layouts": 6,
"layoutDurationMs": 0.647,
"taskDurationMs": 296.19700000000006,
"heapDeltaBytes": 25010320,
"heapUsedBytes": 67569284,
"domNodes": 80,
"jsHeapTotalBytes": 20185088,
"scriptDurationMs": 24.134999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 641.6670000000124,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.581000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.17599999999993,
"heapDeltaBytes": 7393372,
"heapUsedBytes": 50409720,
"domNodes": 20,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 73.565,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 574.6979999999553,
"styleRecalcs": 14,
"styleRecalcDurationMs": 14.189,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 335.867,
"heapDeltaBytes": 6231444,
"heapUsedBytes": 49112088,
"domNodes": 23,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 62.699000000000005,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 550.8659999999281,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.157000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.434,
"heapDeltaBytes": 6197992,
"heapUsedBytes": 49090028,
"domNodes": 20,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 62.90499999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2055.9089999999856,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.051,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.0419999999999,
"heapDeltaBytes": 2839420,
"heapUsedBytes": 54138244,
"domNodes": -259,
"jsHeapTotalBytes": 16551936,
"scriptDurationMs": 106.13399999999999,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.289999999994,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.062000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.921,
"heapDeltaBytes": 5182032,
"heapUsedBytes": 56069372,
"domNodes": -256,
"jsHeapTotalBytes": 15921152,
"scriptDurationMs": 95.109,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.6220000000558,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.229999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 533.671,
"heapDeltaBytes": 4485184,
"heapUsedBytes": 55629068,
"domNodes": -257,
"jsHeapTotalBytes": 16707584,
"scriptDurationMs": 96.703,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2116.5509999999867,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.745000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1105.736,
"heapDeltaBytes": 18419844,
"heapUsedBytes": 72279444,
"domNodes": -263,
"jsHeapTotalBytes": 17698816,
"scriptDurationMs": 419.822,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2136.447999999973,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.834999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1033.6970000000001,
"heapDeltaBytes": 7523232,
"heapUsedBytes": 59429424,
"domNodes": -257,
"jsHeapTotalBytes": 18223104,
"scriptDurationMs": 389.667,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2115.62600000002,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.445,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1096.117,
"heapDeltaBytes": -1921096,
"heapUsedBytes": 53109672,
"domNodes": -264,
"jsHeapTotalBytes": 17465344,
"scriptDurationMs": 407.549,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3147.1559999999954,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.207999999999998,
"layouts": 60,
"layoutDurationMs": 7.2010000000000005,
"taskDurationMs": 1299.874,
"heapDeltaBytes": 6814664,
"heapUsedBytes": 62306132,
"domNodes": -269,
"jsHeapTotalBytes": 17494016,
"scriptDurationMs": 479.497,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3148.1210000000033,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.880999999999998,
"layouts": 60,
"layoutDurationMs": 6.845000000000001,
"taskDurationMs": 1298.287,
"heapDeltaBytes": 7825988,
"heapUsedBytes": 63201588,
"domNodes": -264,
"jsHeapTotalBytes": 17231872,
"scriptDurationMs": 492.91200000000003,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3163.385999999946,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.630999999999998,
"layouts": 60,
"layoutDurationMs": 6.906,
"taskDurationMs": 1297.521,
"heapDeltaBytes": 9678196,
"heapUsedBytes": 64632564,
"domNodes": -264,
"jsHeapTotalBytes": 15921152,
"scriptDurationMs": 490.604,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.7690000000307,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.595999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.5980000000001,
"heapDeltaBytes": 4949128,
"heapUsedBytes": 57881612,
"domNodes": -259,
"jsHeapTotalBytes": 16551936,
"scriptDurationMs": 99.463,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.5949999999675,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.048,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.145,
"heapDeltaBytes": 4184948,
"heapUsedBytes": 56961320,
"domNodes": -259,
"jsHeapTotalBytes": 15659008,
"scriptDurationMs": 93.451,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2045.6219999999803,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.9,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.731,
"heapDeltaBytes": 3389184,
"heapUsedBytes": 57538400,
"domNodes": -264,
"jsHeapTotalBytes": 17231872,
"scriptDurationMs": 87.99900000000001,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 531.9010000000048,
"styleRecalcs": 49,
"styleRecalcDurationMs": 12.856,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.60400000000004,
"heapDeltaBytes": 6789052,
"heapUsedBytes": 49507984,
"domNodes": 22,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 126.13100000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 563.8539999999921,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.253999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 349.38599999999997,
"heapDeltaBytes": 6241252,
"heapUsedBytes": 49297300,
"domNodes": 19,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 123.043,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 556.6180000000713,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.853000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.83700000000005,
"heapDeltaBytes": 6560880,
"heapUsedBytes": 49682500,
"domNodes": 20,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 131.286,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2024.9889999999766,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.716000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 335.22400000000005,
"heapDeltaBytes": 10832560,
"heapUsedBytes": 63153148,
"domNodes": 23,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 17.22,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1991.0130000000095,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.94,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.99,
"heapDeltaBytes": 20217924,
"heapUsedBytes": 63419336,
"domNodes": 23,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 16.222,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2015.7639999999901,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.580000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.352,
"heapDeltaBytes": 11133924,
"heapUsedBytes": 62555460,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 17.07,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2010.6519999999932,
"styleRecalcs": 88,
"styleRecalcDurationMs": 41.702999999999996,
"layouts": 16,
"layoutDurationMs": 4.047000000000001,
"taskDurationMs": 883.515,
"heapDeltaBytes": 11853996,
"heapUsedBytes": 54714504,
"domNodes": 73,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 97.31799999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.162999999994,
"styleRecalcs": 77,
"styleRecalcDurationMs": 34.626,
"layouts": 16,
"layoutDurationMs": 4.2509999999999994,
"taskDurationMs": 638.434,
"heapDeltaBytes": 2850672,
"heapUsedBytes": 54728632,
"domNodes": 65,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 95.49199999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.4179999999524,
"styleRecalcs": 78,
"styleRecalcDurationMs": 36.396,
"layouts": 16,
"layoutDurationMs": 4.4159999999999995,
"taskDurationMs": 663.942,
"heapDeltaBytes": 12024256,
"heapUsedBytes": 55115088,
"domNodes": 65,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 97.015,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8173.880999999994,
"styleRecalcs": 251,
"styleRecalcDurationMs": 43.147000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3884.474,
"heapDeltaBytes": 32206872,
"heapUsedBytes": 83208716,
"domNodes": -256,
"jsHeapTotalBytes": 25825280,
"scriptDurationMs": 1433.95,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8193.339999999978,
"styleRecalcs": 251,
"styleRecalcDurationMs": 42.836,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3595.0229999999997,
"heapDeltaBytes": 30556220,
"heapUsedBytes": 81571676,
"domNodes": -258,
"jsHeapTotalBytes": 20320256,
"scriptDurationMs": 1263.282,
"eventListeners": -107,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8201.348999999936,
"styleRecalcs": 251,
"styleRecalcDurationMs": 44.451,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3544.0190000000002,
"heapDeltaBytes": 631132,
"heapUsedBytes": 51660520,
"domNodes": -256,
"jsHeapTotalBytes": 19591168,
"scriptDurationMs": 1221.403,
"eventListeners": -107,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11187.885999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11176.018,
"heapDeltaBytes": -54932264,
"heapUsedBytes": 158366148,
"domNodes": -8329,
"jsHeapTotalBytes": 17129472,
"scriptDurationMs": 550.6189999999999,
"eventListeners": -16468,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10861.754000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10853.414,
"heapDeltaBytes": -30470176,
"heapUsedBytes": 166940832,
"domNodes": -8329,
"jsHeapTotalBytes": 26828800,
"scriptDurationMs": 546.0279999999999,
"eventListeners": -16466,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11838.275000000067,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11826.155,
"heapDeltaBytes": -33104956,
"heapUsedBytes": 165616672,
"domNodes": -8329,
"jsHeapTotalBytes": 23945216,
"scriptDurationMs": 597.8149999999999,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14413.596999999982,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.763999999999971,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14389.617,
"heapDeltaBytes": -36119728,
"heapUsedBytes": 160564176,
"domNodes": -8329,
"jsHeapTotalBytes": -5500928,
"scriptDurationMs": 835.474,
"eventListeners": -16458,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14205.50099999997,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.976000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14185.126999999999,
"heapDeltaBytes": -47476524,
"heapUsedBytes": 148701352,
"domNodes": -8329,
"jsHeapTotalBytes": -434176,
"scriptDurationMs": 837.3660000000001,
"eventListeners": -16488,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14113.562000000002,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.56099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14081.024999999998,
"heapDeltaBytes": -23722412,
"heapUsedBytes": 160560388,
"domNodes": -8331,
"jsHeapTotalBytes": 19488768,
"scriptDurationMs": 846.4280000000001,
"eventListeners": -16466,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 105.77999999998156,
"styleRecalcs": 10,
"styleRecalcDurationMs": 16.657999999999998,
"layouts": 4,
"layoutDurationMs": 1.585,
"taskDurationMs": 89.923,
"heapDeltaBytes": 2866996,
"heapUsedBytes": 48529476,
"domNodes": 146,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 22.342000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 433.74500000004446,
"styleRecalcs": 16,
"styleRecalcDurationMs": 20.458000000000002,
"layouts": 4,
"layoutDurationMs": 1.1099999999999999,
"taskDurationMs": 103.46699999999998,
"heapDeltaBytes": 4387960,
"heapUsedBytes": 49246112,
"domNodes": 154,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 23.802999999999997,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 117.3110000000861,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.658,
"layouts": 4,
"layoutDurationMs": 1.4649999999999999,
"taskDurationMs": 89.95500000000001,
"heapDeltaBytes": 2745868,
"heapUsedBytes": 48331036,
"domNodes": 139,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 24.871000000000006,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #11873 to
core/1.43.Cherry-picked squash merge commit
04918360ebcf69adffdf5d8ff6603c24c7a2809a.Why
#11873 moves missing asset detection to use exact BLAKE3 hash lookups first when a workflow exposes a valid hash, then falls back to the legacy asset-list matching path for non-hash, invalid, or transiently unverifiable candidates.
For media inputs, the legacy fallback now reads from a separate public-inclusive input asset cache in
assetServiceinstead of reusingassetsStore.inputAssets. That keeps the UI/widget asset list user-only while allowing missing input detection to account for public cloud assets loaded by templates, avoiding false-positive missing media on initial workflow load.Conflict resolution
src/platform/assets/services/assetService.test.ts:core/1.43only had the existingshouldUseAssetBrowsercoverage, while Use hash lookup for missing asset detection #11873 adds asset hash, upload validation, pagination, and public-inclusive input cache tests. Kept the Use hash lookup for missing asset detection #11873 test expansion; the existing test coverage is preserved in the incoming file.src/stores/assetsStore.test.ts: expanded the mockedassetServicesurface and kept Use hash lookup for missing asset detection #11873's appended store tests for asset metadata/tag updates, deletion state, input name mapping, and input cache invalidation. The runtimeassetsStore.tschanges auto-merged cleanly.Validation
pnpm test:unit -- run src/platform/assets/services/assetService.test.ts src/stores/assetsStore.test.ts✅ (91/91 passing)pnpm typecheck✅pnpm exec oxfmt --check src/platform/assets/services/assetService.ts src/platform/assets/services/assetService.test.ts src/platform/missingMedia/missingMediaScan.ts src/platform/missingMedia/missingMediaScan.test.ts src/platform/missingModel/missingModelScan.ts src/platform/missingModel/missingModelScan.test.ts src/stores/assetsStore.ts src/stores/assetsStore.test.ts✅git diff --check✅oxfmt,oxlint,eslint, andpnpm typecheckon the changed files ✅pnpm knip --cache✅Original PR: #11873
Original commit:
04918360ebcf69adffdf5d8ff6603c24c7a2809a┆Issue is synchronized with this Notion page by Unito