[#544] Make fee accounting and rounding invariant-safe - #564
Merged
1nonlypiece merged 2 commits intoAug 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\nThis PR centralizes fee arithmetic and makes every supported fee lifecycle use a conservation-safe split.\n\n- adds checked quotient/remainder arithmetic that avoids intermediate multiplication overflow;\n- makes rate and amount validation explicit and fail closed;\n- returns gross, fee, net, and rounding remainder together;\n- supports optional persisted remainder carry for repeated dust-sized operations;\n- wires the policy into commitment creation and early-exit accounting;\n- wires the same policy into marketplace listings, offers, and auction settlement;\n- rejects invalid marketplace configuration instead of silently clamping it;\n- adds boundary, large-value, carry, ledger, and conservation tests;\n- documents rounding, lifecycle ordering, events, reconciliation, and upgrade rules.\n\nThe change set contains 521 added lines of implementation, tests, and accounting documentation.\n\n## Validation\n\n- \n- (blocked by the repository's existing Rust/toolchain incompatibility in dependency , before project code compilation)\n\nCloses #544