[#545] Make marketplace escrow settlement atomic - #565
Open
greatest0fallt1me wants to merge 1 commit into
Open
greatest0fallt1me wants to merge 1 commit into
greatest0fallt1me wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Acceptance criteria
Design notes
The flow is organized as check, interact, then commit. The reentrancy guard remains active through token calls. A failed invocation exits before the commit block, while a successful invocation removes only the settled listing and its royalty record. The gross buyer debit is checked before the split so fee and royalty rounding cannot underfund the transfer path.
Verification
git diff --checkpasses.cargo test -p commitment-marketplacewas attempted but is currently blocked before test compilation by the repository dependencyethnum v1.5.2using an invalid zero-sized transmute with rustc 1.97.1.Limitations
The existing contract stores the NFT address but does not perform a cross-contract NFT transfer; adding escrow/approval authority is outside this issue. Offers and auctions retain their separate settlement paths.
Closes #545