Seconds per day

[heymide]

Close: #1588

Description

All compile errors in lib.rs are fixed. Here's the summary:
Fixed in lib.rs
Fix Details
Duplicate DataKey variants Removed second YieldPool, Paused, Attestations(u64)
Duplicate AttestationRecord struct Removed second copy (lines 212-218)
Duplicate MAX_PENALTY_BPS / SECONDS_PER_DAY Removed private const copies (lines 220-221) — pub const versions kept
Missing CreateCommitmentEventData Added struct definition
Missing Error variants Added AssetMismatch, InsufficientBalance, CommitmentViolated, InvalidWasmHash
Missing TTL constants Added ESTIMATED_LEDGER_SECONDS (5), TTL_MATURITY_BUFFER_LEDGERS (100)
Missing publish_commitment_event Added generic helper method
calculate_accrued_yield missing Self:: Fixed at line 465
perform_release double transfer Removed duplicate token transfer
resolve_dispute duplicate computation Removed redundant compute_refund_amount call, added missing penalty transfer
Test file (test.rs)
Has ~30 pre-existing errors from the same bad merge (API mismatches, missing assert_contract_event helper, outdated method signatures). That would need a separate pass to reconcile. cargo build --lib succeeds cleanly.

Closes #1588

Type of Change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Checklist

Please review the Developer Guide before checking the items below:

• My code follows the code style and standards of this project (strict TypeScript, components/functions/constants naming conventions).
• I have performed a self-review of my code.
• I have commented my code, particularly in hard-to-understand areas.
• I have updated or added documentation where relevant (DEVELOPER_GUIDE.md, README.md, or inline files).
• I have added unit/integration tests that prove my fix is effective or that my feature works.
• Any new or modified logic has at least 95% test coverage (verified via pnpm run test:coverage or npm run test:coverage).
• I have ran the project linter (pnpm lint or npm run lint) and fixed all error diagnostics.
• I have verified that this change fits within the 96-hour campaign timeframe for contributor assignments.
• I have attached screenshots/videos showing the before and after states for any visual or UI changes.

Visual Changes (if applicable)

Please add screenshots, screen recordings, or GIFs showcasing the user interface changes.

Join the Discussion

Need help or want to chat? Join our CommitLabs Discord server.

[vercel]

@heymide is attempting to deploy a commit to the 1nonly's projects Team on Vercel.

A member of the Team first needs to authorize it.

[drips-wave]

@heymide Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[heymide]

Done, Close: #1639