ROM revision --- deeper changes#308
Open
OlivierBBB wants to merge 13 commits intomainfrom
Open
Conversation
There was a problem hiding this comment.
Bug: Undefined variable in oobCallToDiv macro refactor
The \oobCallToDiv macro uses the undefined variable \locMax in the expression {\locMax + 7}. This looks like a refactoring oversight; \locMaxMbsBbs is defined and appears to be the intended variable here.
oob/precompiles/modexp/pricing.tex#L45-L46
linea-specification/oob/precompiles/modexp/pricing.tex
Lines 45 to 46 in f1f64a8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Overhauls the ROM module (new columns, padding and constraint model), streamlines MODEXP handling and pricing across HUB/OOB, updates block-hash/jumpdest lookups, and replaces/moderns precompile helper macros.
romColumn*), explicit padding semantics, and revised constancy/binarity/heartbeat constraints.PUSH_VALUE, claimed-by-push), and jumpdest analysis; updates instruction decoder lookup.XBSchecks/max, and extraction gating.BLOCKHASHlookup and updates jumpdest vetting to targetopcodeIsJumpDest.oobCallTo{Div,Mod}and refactors precompile call macros (simpler signatures); removes legacymod_calls.pkg/rom.stywith new column aliases; minor includes/ordering in hub/spec.mxp_v2,rlp_txn_v2,rom_v3).Written by Cursor Bugbot for commit f1f64a8. This will update automatically on new commits. Configure here.