-
Notifications
You must be signed in to change notification settings - Fork 21
feat: blob transactions #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 8 commits
f8a8a97
b94e1ee
fbfc898
635b859
34bd39b
20b251c
cdf1580
1d97454
a666d81
a3ce44d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| We impose the following | ||
| \begin{enumerate} | ||
| \item | ||
| \rlpTxnCommonColumnNumberOfBlobs{} \textbf{transaction-constant} | ||
|
cursor[bot] marked this conversation as resolved.
|
||
| \item $\typeThreeTx_{i} = 0$ \Then $\rlpTxnCommonColumnNumberOfBlobs_{i} = 0$ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing conditional keyword in constraintMedium Severity The constraint for non-type-3 transactions is missing the |
||
| \end{enumerate} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Macro uses wrong name for output rendering
Medium Severity
The
\rlpProcessBlobHashmacro definition uses\rlpProcessBytesThirtyTwoNameinstead of the newly defined\rlpProcessBlobHashName. This causes the output to render as "BYTES32" instead of "BLOBHASH", making the specification inconsistent and potentially confusing when distinguishing blob hash processing from general 32-byte processing.