Skip to content

Support enable date on non-PV node in alarm config #3809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
georgweiss wants to merge 7 commits into
base: master
Choose a base branch
from

Fix bug, convert rest of alarm config dialog to fxml

f0251d7
Select commit
Loading
Failed to load commit list.
Open

Support enable date on non-PV node in alarm config #3809

Fix bug, convert rest of alarm config dialog to fxml
f0251d7
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 1, 2026 in 2m 41s

Quality Gate passed

Issues
55 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 69 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/config/ComponentConfigDialogController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"enabled" is the name of a field in "ConfigDialogController". 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHgyoTWlItriCU2a&open=AZ5pWHgyoTWlItriCU2a&pullRequest=3809

Check warning on line 18 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make automatedActions a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ6DP5yexiiWicRxcNXI&open=AZ6DP5yexiiWicRxcNXI&pullRequest=3809

Check failure on line 49 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/config/TitleDetailDelayTableController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ6DP5tuxiiWicRxcNXA&open=AZ6DP5tuxiiWicRxcNXA&pullRequest=3809

Check warning on line 86 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/config/ItemConfigDialog.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pmu8v32CQ4Fuhlqe1&open=AZ5pmu8v32CQ4Fuhlqe1&pullRequest=3809

Check warning on line 40 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static promptContent" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU2_&open=AZ5pWHlQoTWlItriCU2_&pullRequest=3809

Check warning on line 39 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static promptTitle" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU2-&open=AZ5pWHlQoTWlItriCU2-&pullRequest=3809

Check warning on line 32 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static headerAlreadyDisabled" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU25&open=AZ5pWHlQoTWlItriCU25&pullRequest=3809

Check warning on line 31 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static guidance" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ6DP5yexiiWicRxcNXP&open=AZ6DP5yexiiWicRxcNXP&pullRequest=3809

Check warning on line 20 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static configure" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU2z&open=AZ5pWHlQoTWlItriCU2z&pullRequest=3809

Check warning on line 216 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/config/TitleDetailDelayTableController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ6DP5tuxiiWicRxcNW_&open=AZ6DP5tuxiiWicRxcNW_&pullRequest=3809

Check failure on line 53 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/config/TitleDetailDelayTableController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ6DP5tuxiiWicRxcNXB&open=AZ6DP5tuxiiWicRxcNXB&pullRequest=3809

Check warning on line 30 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static enableAlarms" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU24&open=AZ5pWHlQoTWlItriCU24&pullRequest=3809

Check warning on line 23 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make delayTooltip2 a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU2p&open=AZ5pWHlQoTWlItriCU2p&pullRequest=3809

Check warning on line 33 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make headerAlreadyEnabled a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU2t&open=AZ5pWHlQoTWlItriCU2t&pullRequest=3809

Check warning on line 123 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/config/TitleDetailTableController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ6DP5xSxiiWicRxcNXG&open=AZ6DP5xSxiiWicRxcNXG&pullRequest=3809

Check warning on line 25 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/tree/ComponentActionHelper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a private constructor to hide the implicit public one. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHkqoTWlItriCU2j&open=AZ5pWHkqoTWlItriCU2j&pullRequest=3809

Check warning on line 25 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make disableAlarms a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU2q&open=AZ5pWHlQoTWlItriCU2q&pullRequest=3809

Check warning on line 35 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static headerConfirmDisableWithEnableDate" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU28&open=AZ5pWHlQoTWlItriCU28&pullRequest=3809

Check failure on line 35 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/tree/ComponentActionHelper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 30 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHkqoTWlItriCU2k&open=AZ5pWHkqoTWlItriCU2k&pullRequest=3809

Check warning on line 205 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/config/ComponentConfigDialogController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof AlarmClientLeaf pv' 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHgyoTWlItriCU2e&open=AZ5pWHgyoTWlItriCU2e&pullRequest=3809

Check warning on line 87 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/config/ConfigDialogController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change the visibility of this constructor to "protected". 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHkgoTWlItriCU2i&open=AZ5pWHkgoTWlItriCU2i&pullRequest=3809

Check warning on line 94 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/config/ComponentConfigDialogController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the "@Override" annotation above this method signature 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHgyoTWlItriCU2d&open=AZ5pWHgyoTWlItriCU2d&pullRequest=3809

Check failure on line 76 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/config/ComponentConfigDialogController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"relativeDate" is the name of a field in "ConfigDialogController". 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHgyoTWlItriCU2b&open=AZ5pWHgyoTWlItriCU2b&pullRequest=3809

Check warning on line 30 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make enableAlarms a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU2r&open=AZ5pWHlQoTWlItriCU2r&pullRequest=3809

Check warning on line 32 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make headerAlreadyDisabled a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU2s&open=AZ5pWHlQoTWlItriCU2s&pullRequest=3809
View more details on SonarQubeCloud