Skip to content

Writing plt file must consider ordering of PVs vs formulas #3816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shroffk merged 3 commits into from
Jun 5, 2026
+739 −248

Additional junit tests generated by Claude

c43f1fc
Select commit
Loading
Failed to load commit list.
Merged

Writing plt file must consider ordering of PVs vs formulas #3816

Additional junit tests generated by Claude
c43f1fc
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jun 2, 2026 in 2m 40s

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 197 in app/databrowser/src/main/java/org/csstudio/trends/databrowser3/persistence/XMLPersistence.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch Exception instead of Throwable. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ6IGWDZ2AdJs5XKRTZG&open=AZ6IGWDZ2AdJs5XKRTZG&pullRequest=3816

Check failure on line 392 in app/databrowser/src/main/java/org/csstudio/trends/databrowser3/persistence/XMLPersistence.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a default case to this switch. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ6IGWDZ2AdJs5XKRTZI&open=AZ6IGWDZ2AdJs5XKRTZI&pullRequest=3816

Check warning on line 259 in app/databrowser/src/main/java/org/csstudio/trends/databrowser3/persistence/XMLPersistence.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch Exception instead of Throwable. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ6IGWDZ2AdJs5XKRTZH&open=AZ6IGWDZ2AdJs5XKRTZH&pullRequest=3816

Check warning on line 56 in app/databrowser/src/main/java/org/csstudio/trends/databrowser3/persistence/XMLPersistence.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a private constructor to hide the implicit public one. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ6IGWDZ2AdJs5XKRTZE&open=AZ6IGWDZ2AdJs5XKRTZE&pullRequest=3816

Check warning on line 433 in app/databrowser/src/test/java/org/csstudio/trends/databrowser3/persistence/XMLPersistenceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ6IGWGV2AdJs5XKRTZJ&open=AZ6IGWGV2AdJs5XKRTZJ&pullRequest=3816

Check failure on line 153 in app/databrowser/src/main/java/org/csstudio/trends/databrowser3/persistence/XMLPersistence.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 70 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ6IGWDZ2AdJs5XKRTZF&open=AZ6IGWDZ2AdJs5XKRTZF&pullRequest=3816
View more details on SonarQubeCloud