You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
NOTE: this PR may be irrelevant in case I have misunderstood the Enabled property on the TableWidget. In any case...
When marking a TableWidget as non-editable, all columns should also be marked as non-editable. Conversely, if all columns are marked non.editable, then the table should also be marked as non-editable.
Testing:
The feature has automated tests
Tests were run
If not, explain how you tested your changes
Documentation:
The feature is documented
The documentation is up to date
Release notes:
Added an entry if the change is breaking or significant
I think you understand correctly, there is some interplay, and the overall table flag has precedence:
Table not editable: The per-column flags don't matter, the table is read-only.
Table editable: The per-column flags decide if a specific column really is editable.
All columns non-editable: Would be nice to mark the table as non-editable as well, since it de facto is.
As far as I know, all the tables we use here are either generally editable or not.
The use case where the table per se is editable but some columns are not hasn't been used here, but maybe somebody has tables configured that way so now it's too late to remove the per-column 'editable' flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: this PR may be irrelevant in case I have misunderstood the Enabled property on the TableWidget. In any case...
When marking a TableWidget as non-editable, all columns should also be marked as non-editable. Conversely, if all columns are marked non.editable, then the table should also be marked as non-editable.
Testing:
Documentation: