Skip to content

Update TableWidget editable properties consistently#3817

Open
georgweiss wants to merge 2 commits into
masterfrom
CSSTUDIO-1941
Open

Update TableWidget editable properties consistently#3817
georgweiss wants to merge 2 commits into
masterfrom
CSSTUDIO-1941

Conversation

@georgweiss
Copy link
Copy Markdown
Collaborator

NOTE: this PR may be irrelevant in case I have misunderstood the Enabled property on the TableWidget. In any case...

When marking a TableWidget as non-editable, all columns should also be marked as non-editable. Conversely, if all columns are marked non.editable, then the table should also be marked as non-editable.

  • Testing:

    • The feature has automated tests
    • Tests were run
    • If not, explain how you tested your changes
  • Documentation:

    • The feature is documented
    • The documentation is up to date
    • Release notes:
      • Added an entry if the change is breaking or significant
      • Added an entry when adding a new feature

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 2, 2026

@kasemir
Copy link
Copy Markdown
Collaborator

kasemir commented Jun 2, 2026

I think you understand correctly, there is some interplay, and the overall table flag has precedence:

Table not editable: The per-column flags don't matter, the table is read-only.
Table editable: The per-column flags decide if a specific column really is editable.
All columns non-editable: Would be nice to mark the table as non-editable as well, since it de facto is.

As far as I know, all the tables we use here are either generally editable or not.
The use case where the table per se is editable but some columns are not hasn't been used here, but maybe somebody has tables configured that way so now it's too late to remove the per-column 'editable' flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants