feat(env): support multiple environment variables#15
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for specifying multiple environment variables as fallbacks for a single configuration field. Instead of accepting only a single string for the env property, it now accepts either a string or an array of strings, where the first found environment variable is used.
Key changes:
- Updated type definition to allow string arrays for environment variable names
- Modified environment resolution logic to iterate through multiple variables and use the first found
- Added comprehensive test coverage for the new fallback behavior
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/figue.types.ts | Updated ConfigDefinitionElement type to accept string array for env property |
| src/figue.ts | Implemented fallback logic to find first available environment variable from array |
| src/figue.test.ts | Added test cases covering multiple environment variable scenarios |
| README.md | Added documentation explaining the new environment variable fallback feature |
Comments suppressed due to low confidence (1)
README.md:1
- Typo in comment: 'plateform' should be 'platform'.
<p align="center">
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.