feat(figue): add cross-field validation support#22
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces cross-field (per-field hook) validation to defineConfig, enabling rules that validate a field using the fully validated/coerced config object (e.g., “defaultAdapterId must exist in adapters[]”).
Changes:
- Added
validatehook support on config definition leaves, executed after successful schema validation, aggregating issues into the existingConfigValidationError. - Added public validation types (
ValidateFn,ValidateIssue,ValidateResult) and avalidator(...)helper for improved typing ergonomics. - Documented cross-field validation usage in the README and added comprehensive tests for the new behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.ts | Re-exports validator and validation-related types as part of the public API. |
| src/figue.types.ts | Introduces the validate hook types and adds validate to ConfigDefinitionElement. |
| src/figue.ts | Implements validate hook execution/normalization and exposes the validator helper. |
| src/figue.test.ts | Adds tests covering validate hook contracts, error aggregation, and typed helper usage. |
| README.md | Adds user-facing documentation for cross-field validation and return contracts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+99
to
+101
| export function validator<Config = any, Value = any>(fn: ValidateFn<Value, Config>): ValidateFn<Value, Config> { | ||
| return fn; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.