Restore safe End portal falling-block duplication - #307
Merged
Conversation
BaconCat1
marked this pull request as draft
July 30, 2026 01:03
BaconCat1
marked this pull request as ready for review
July 30, 2026 14:30
Dueris
added
bug
Dueris
requested changes
Jul 31, 2026
Member
|
Are you able to test this issue report to see if it works? Specifically the YT link in there. |
Contributor
Author
I already did and it does work |
Dueris
requested changes
Aug 3, 2026
R00tB33rMan
approved these changes
Aug 4, 2026
R00tB33rMan
left a comment
R00tB33rMan
left a comment
Member
There was a problem hiding this comment.
From a glance from prior reviews looks fine
Contributor
|
I think it's fine, I tested it locally and seems to work? Code looks good to me overall |
devnootnoot
self-requested a review
August 10, 2026 19:06
devnootnoot
approved these changes
Aug 10, 2026
Dueris
requested changes
Aug 11, 2026
Dueris
approved these changes
Aug 11, 2026
Member
|
Please fix conflicts with the main branch. Comment when done and Ill merge. Final call for everyone else if you wanna review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #271
This restores normal End portal gravity-block duping when Paper's existing
allow-unsafe-end-portal-teleportationsetting is enabled. When it is disabled, nothing changes and Canvas keeps the current behavior.The main problem with the other suggested implementations is that they keep ticking the original falling block after the portal transfer has already removed or invalidated it. That violates Folia's region ownership invariant. This instead prepares a separate source-side continuation before the transfer finishes. It gets a fresh UUID, copies the falling block's state without yoinking its Bukkit wrapper, clears its portal state, and is properly registered in the source world before any tick logic runs.
The continuation skips the part of the tick that already happened, like gravity, movement, and portal handling, then runs the unchanged landing and placement logic that traditional sand dupers need. It is discarded immediately afterward so it cannot tick again or go through the portal twice.
Testing
I rebuilt and applied the full patch stack, compiled
canvas-server, tested multiple End portal duping machines from YouTube on a local server, and also verified it with a local regression test.